rates in dps for iNav > 1.1.0, see iNavFlight#204 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var FC = { | ||
| isRatesInDps: function () { | ||
| if (typeof CONFIG != "undefined" && CONFIG.flightControllerIdentifier == "INAV" && semver.gt(CONFIG.flightControllerVersion, "1.1.0")) { |
Member
There was a problem hiding this comment.
No need to check for INAV really, Configurator won't connect to anything but INAV so we can safely remove most of compatibility stuff from Cleanflight.
azolyoung
pushed a commit
to azolyoung/inav-configurator
that referenced
this pull request
Oct 19, 2017
DzikuVx
pushed a commit
that referenced
this pull request
Nov 10, 2020
Merge from inav-configurator master
davidbuzz
added a commit
to davidbuzz/ardu-configurator
that referenced
this pull request
Sep 3, 2021
separate vcc, battery voltages & fix displayed batt voltage
sensei-hacker
added a commit
that referenced
this pull request
Dec 4, 2025
Bug #1: Update GPS example to use 'gpsSats' property - The API property was renamed from 'gpsNumSat' to 'gpsSats' - GPS Fix Check example was not updated, causing transpilation errors - Fixed examples/index.js lines 120, 124 Bug #2: Fix waypoint example to use 'distance' property - Example incorrectly used 'waypoint.distanceToHome' - Correct property is 'waypoint.distance' (distance to current waypoint) - Fixed examples/index.js lines 185, 189 Bug #3: Add null checks in property_access_checker.js - Missing null check caused crash: "Cannot read properties of undefined (reading 'targets')" - Affected "Altitude-based Stages" and other override examples - Added defensive checks for apiObj, apiObj.targets, apiObj.nested - Fixed property_access_checker.js lines 170-181 Fixes: - "GPS Fix Check" example now transpiles successfully - "Waypoint Arrival Detection" example now transpiles successfully - "Altitude-based Stages" example now transpiles successfully - All 15 examples validated Users can now successfully use all built-in examples without errors.
sensei-hacker
added a commit
that referenced
this pull request
Dec 12, 2025
The test_flight_axis_override.js file had multiple bugs preventing tests from running correctly: **Fix #1: Missing Decompiler import** - Added `import { Decompiler } from '../decompiler.js';` - Changed `transpiler.decompile()` to proper `new Decompiler()` usage - Error was: "transpiler.decompile is not a function" **Fix #2: Invalid property name in Test 4** - Fixed `flight.armed` → `flight.isArmed` - Error was: "Unknown property 'armed' in 'flight.armed'" - The correct property is `isArmed` per the flight API **Fix #3: Error message handling** - Fixed `result.errors` → `result.error || result.errors` - Fixed `decompiled.errors` → `decompiled.error || decompiled.errors` - Handles both singular and plural error field names **Test Results:** Before: 3 decompile errors, 1 compilation failure After: All 4 tests pass ✅ - Test 1: Roll angle override ✅ - Test 2: Pitch rate override ✅ - Test 3: Yaw angle override ✅ - Test 4: Multiple axis overrides ✅
sensei-hacker
added a commit
that referenced
this pull request
Dec 19, 2025
When handleNot() encounters NOT(OR(...)) or NOT(AND(...)), it was directly inlining the inner LC's operands. This bypassed the hoisting system, causing activator relationships to be lost. Example bug: - LC 23: OR(rth, poshold), Active when profile==2 - LC 24: NOT(LC23) - Before: `if (!(rth || poshold))` - activator ignored! - After: `if (!cond3)` where cond3 respects profile check Fix: Only apply structural optimizations (NOT(OR)->!(||), etc.) when the inner LC has no activator (activatorId === -1). If it has an activator, fall through to decompileOperand which returns the hoisted variable name. Verified against INAV firmware: logic_condition.c:568 confirms that when an LC's activator is false, its value is set to 0. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PID Tuning shows rates in dps in compatible versions of iNav
See #204