-
Notifications
You must be signed in to change notification settings - Fork 370
Add Power Limiting UI to Configuration Tab #2482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: maintenance-9.x
Are you sure you want to change the base?
Add Power Limiting UI to Configuration Tab #2482
Conversation
Branch Targeting SuggestionYou've targeted the
If This is an automated suggestion to help route contributions to the appropriate branch. |
PR Compliance Guide 🔍All compliance sections have been disabled in the configurations. |
eb6a9f6 to
b3b12cb
Compare
Add user interface for configuring power and current limiting settings in the Configurator's Configuration tab. These settings have existed in the firmware since INAV 3.0.0 but were not exposed in the GUI. Changes: - Added Power Limiting section to configuration.html after Battery settings - Added 8 input fields for power limit configuration: * Current limits: continuous, burst, burst time, falldown time * Power limits: continuous, burst, burst time, falldown time - Added comprehensive i18n strings in locale/en/messages.json - All inputs use batteryProfileHighlight class (part of battery profile) - All settings use data-setting-placeholder for auto-sync with firmware UI Features: - Help tooltips for each setting explaining units and examples - Info note explaining feature requires current sensor - Settings grouped logically (current limits, then power limits) - Units clearly shown: dA (deci-amps), dW (deci-watts), ds (deci-seconds) Users can now easily configure battery protection without using CLI. Settings are stored in battery profiles allowing different limits per battery type. Related: - INAV PR #6929 (original power limits implementation) - INAV PR #11187 (documentation)
Two fixes: 1. Fixed data-setting attribute (bug fix) - Changed data-setting-placeholder to data-setting on all 8 fields - Settings.saveInputs() only processes data-setting attributes - This was preventing values from being saved 2. Fixed duplicate labels (UX improvement) - "Burst Time" → "Burst Current Time" / "Burst Power Time" - "Burst Falldown Time" → "Burst Current Falldown Time" / "Burst Power Falldown Time" - Eliminates confusion between current and power timing fields Note: i18n strings only added to English (en). Other languages (ja, ru, uk, zh_CN) will fall back to English until proper translations are provided.
b3b12cb to
1750232
Compare
User description
Summary
Adds user interface for configuring power and current limiting settings in the Configuration tab. These firmware settings have existed since INAV 3.0.0 but were never exposed in the Configurator GUI, requiring users to use CLI commands.
Problem
Power limiting is a valuable battery protection feature that:
Changes
Added to
tabs/configuration.html:limit_cont_current,limit_burst_current,limit_burst_current_time,limit_burst_current_falldown_timelimit_cont_power,limit_burst_power,limit_burst_power_time,limit_burst_power_falldown_timeAdded to
locale/en/messages.json:Technical Implementation:
batteryProfileHighlightclass (settings are per battery profile)data-setting-placeholderfor automatic firmware syncBenefits
Testing
Tested with INAV Configurator:
Screenshots
(Screenshots would go here showing the new Power Limiting section)
Related
Notes
PR Type
Enhancement
Description
This description is generated by an AI tool. It may have inaccuracies
Adds Power Limiting UI configuration section to the Configuration tab, exposing firmware settings that have existed since INAV 3.0.0 but were previously only accessible via CLI
Implements 8 new input fields for configuring current and power limiting parameters:
limit_cont_current,limit_burst_current,limit_burst_current_time,limit_burst_current_falldown_timelimit_cont_power,limit_burst_power,limit_burst_power_time,limit_burst_power_falldown_timeAdds 14 new internationalization strings to
locale/en/messages.jsonwith clear unit explanations and practical examplesIntegrates with battery profile system using
batteryProfileHighlightclass for per-profile configurationFollows existing configurator patterns with automatic firmware synchronization via
data-setting-placeholderImproves feature discoverability and usability by providing GUI access instead of requiring CLI commands
Includes help tooltips for each setting to guide users on proper configuration
Diagram Walkthrough
File Walkthrough