Skip to content

Conversation

@emmadesilva
Copy link
Member

@emmadesilva emmadesilva commented Nov 10, 2024

Abstract

This pull request for HydePHP v2 brings several improvements on how we handle assets in HydePHP. It brings a complete rewrite of the HydeFront asset handling system, replacing Laravel Mix with Vite, and favouring Blade-based components with Tailwind classes over CSS partials and custom stylesheets.

Introduces Vite

In these pull requests we replaced Laravel Mix with Vite:

HydeFront v4

We are updating how HydeFront is handled for v2. Instead of declaring styles directly in HydeFront alongside Tailwind, we will refactor those styles into Tailwind.

HydeFront will serve two main purposes:

  1. It will continue to include the precompiled app.css file bundled with new apps, available through the HydeFront CDN.
  2. It will act as a component library, allowing users to include granular styles from app.css, which we will preconfigure.

For example, users can include our Tailwind styles granularly using just the app.css file from the HydeFront package. This file will be compiled alongside Tailwind. If users prefer customization, they can remove the import and add the specific styles they want.

Related Changes

@codecov
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (54012db) to head (b38248c).
Report is 513 commits behind head on 2.x-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##             2.x-dev     #2006    +/-   ##
============================================
  Coverage     100.00%   100.00%            
- Complexity      1891      1939    +48     
============================================
  Files            194       196     +2     
  Lines           5044      5160   +116     
============================================
+ Hits            5044      5160   +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva added the run-visual-tests Internal label to trigger Browserstack visual testing label Nov 11, 2024
@emmadesilva emmadesilva force-pushed the new-asset-system branch 2 times, most recently from 17f9df0 to c07f27f Compare November 11, 2024 20:04
@emmadesilva emmadesilva removed the run-visual-tests Internal label to trigger Browserstack visual testing label Nov 15, 2024
@emmadesilva emmadesilva force-pushed the new-asset-system branch 2 times, most recently from d335c54 to c2f76be Compare November 17, 2024 11:17
@emmadesilva emmadesilva merged commit cc21b86 into 2.x-dev Dec 8, 2024
7 checks passed
@emmadesilva emmadesilva deleted the new-asset-system branch December 8, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants