-
-
Notifications
You must be signed in to change notification settings - Fork 12
[2.x] Replace --run-dev and --run-prod build command flags with --run-vite flag
#2013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## new-asset-system #2013 +/- ##
======================================================
- Coverage 100.00% 99.98% -0.02%
- Complexity 1891 1892 +1
======================================================
Files 194 194
Lines 5044 5044
======================================================
- Hits 5044 5043 -1
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. |
31eb157 to
7e998a2
Compare
74d2278 to
9f3c99f
Compare
--run-dev and --run-prod build command flags with --run-vite--run-dev and --run-prod build command flags with --run-vite flag
Alternate Name Considerations:Before choosing the option name Alternatives:
Motivations for
Motivations Against Other Options:
|
41e57b9 to
25bbab8
Compare
[2.x] Replace `--run-dev` and `--run-prod` build command flags with `--run-vite` flag
|
Replace Mix build flags with Vite flag
Description
This PR replaces the
--run-devand--run-prodbuild command flags with a single--run-viteflag. This change is needed because we switched from Laravel Mix to Vite in #2010, which has different commands and behaviors:npm run devwith Vite starts a development server (incompatible with our build process)npm run prodno longer exists, replaced bynpm run buildThe new
--run-viteflag will:npm run buildto compile assets with Vite_site/media(see [2.x] No longer copy files to site output from the asset bundler command #2011)Breaking Changes
--run-devflag--run-prodflag--run-viteflagRelated Issues/PRs
Upgrade Guide
Replace any usage of
--run-devor--run-prodwith--run-vite: