Skip to content

Conversation

@emmadesilva
Copy link
Member

@emmadesilva emmadesilva commented Nov 17, 2024

This approach has several benefits:

  1. Users can easily opt-out of specific styles by removing the import.
  2. Users can override specific components by:
    • Removing the import and copying the styles they want to customize.
    • Or keeping the import and adding overriding styles after (since CSS cascade order matters).
  3. The code is more maintainable as each feature's styles are isolated.
  4. It's clearer what each set of styles does.
  5. Users can see exactly what styles they're getting from HydeFront.
  6. The app.css file is clean and Laravely 👌

It also further normalizes the code block implementations #2036

@emmadesilva emmadesilva added the run-visual-tests Internal label to trigger Browserstack visual testing label Nov 17, 2024
@codecov
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4aee3cd) to head (649bbe9).
Report is 13 commits behind head on refactor-hydefront-styles-to-tailwind.

Additional details and impacted files
@@                            Coverage Diff                            @@
##             refactor-hydefront-styles-to-tailwind     #2038   +/-   ##
=========================================================================
  Coverage                                   100.00%   100.00%           
  Complexity                                    1906      1906           
=========================================================================
  Files                                          195       195           
  Lines                                         5080      5080           
=========================================================================
  Hits                                          5080      5080           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva force-pushed the extract-hydefront-partials-for-tailwind-components branch from 9165630 to 8838fe0 Compare November 17, 2024 17:52
@emmadesilva emmadesilva merged commit fbd70d9 into refactor-hydefront-styles-to-tailwind Nov 17, 2024
10 checks passed
@emmadesilva emmadesilva deleted the extract-hydefront-partials-for-tailwind-components branch November 17, 2024 18:04
@github-actions github-actions bot removed the run-visual-tests Internal label to trigger Browserstack visual testing label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants