Skip to content

Conversation

@emmadesilva
Copy link
Member

@emmadesilva emmadesilva commented Nov 16, 2024

Replaces the HydeSearch plugin with an Alpine.js and Blade implementation to make it more customizable and to reduce external dependencies. It also lets us more easily couple fixes and improvements to Hyde versions.

@emmadesilva emmadesilva changed the title [2.x] Recreate the HydeSearct plugin with Alpine.js [2.x] Recreate the HydeSearch plugin with Alpine.js Nov 16, 2024
@codecov
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4575d7f) to head (5782c86).
Report is 31 commits behind head on refactor-hydefront-styles-to-tailwind.

Additional details and impacted files
@@                            Coverage Diff                            @@
##             refactor-hydefront-styles-to-tailwind     #2029   +/-   ##
=========================================================================
  Coverage                                   100.00%   100.00%           
  Complexity                                    1906      1906           
=========================================================================
  Files                                          195       195           
  Lines                                         5078      5078           
=========================================================================
  Hits                                          5078      5078           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva
Copy link
Member Author

I think it makes sense to hide the keyboard shortcut help text when there are search results, for a few reasons:

  1. Once users are actively searching/viewing results, the shortcuts become less relevant
  2. The space could be better used for showing more results
  3. There are multiple obvious ways to exit the modal:
    • The ESC key (which is a common pattern across the web)
    • Clicking the X button in the header
    • Clicking outside the modal (click-away behavior)
    • The search button is still visible

@emmadesilva emmadesilva marked this pull request as ready for review November 16, 2024 18:45
@emmadesilva emmadesilva mentioned this pull request Nov 16, 2024
17 tasks
@emmadesilva emmadesilva merged commit 1f4e3d4 into refactor-hydefront-styles-to-tailwind Nov 16, 2024
12 checks passed
@emmadesilva emmadesilva deleted the recreate-the-hydesearch-plugin-with-alpine branch November 16, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants