Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make image list packing architecture awared (backport #682 and #690) #691

Conversation

brandboat
Copy link
Contributor

@brandboat brandboat commented Mar 29, 2024

backport #682 and #690 to branch v1.3

Problem:
The script archive-image-lists.sh lacks architecture awareness and could potentially lead to failures within our CI pipeline, particularly if newer versions (> 1.3.0) have been released.

Solution:
Compare the version in upgrade-matrix.yaml with v1.3.0, if version >= v1.3.0, which means that version already support different architecture images, and we need to download the image lists tarball from https://releases.rancher.com/harvester/{VERSION}/image-lists-{ARCH}.tar.gz.

Related Issue:
harvester/harvester#5313

Test plan:

  1. Download harvester repo
  2. replace this line with git clone --branch HARV-5313 --single-branch --depth 1 https://github.com/brandboat/harvester-installer.git ../harvester-installer
  3. add below yaml code snippet to upgrade-matrix.yaml
- name: v1.3.0
  minUpgradableVersion: v1.2.1
  1. execute make build-iso without error
    As you can see the console output shows that the script download v1.3.0 image list tarball with a specific architecture amd64, while others still use generic URL without architecture specification.
    image
    image

@bk201 bk201 merged commit cc1b789 into harvester:v1.3 Mar 29, 2024
5 checks passed
@brandboat brandboat deleted the back-port-make-image-list-packing-architecture-awared branch March 29, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants