[BUG] The image list packing part of the build script should be architecture-aware

[starbops]

Describe the bug

We will soon publish ARM64 artifacts for the v1.3.0 release. The build pipeline includes an image list packing stage, which packs the image lists for the current and previous versions (ref). It isn't arch-aware yet, so the results (the packed image lists) will be the same for both AMD64 and ARM64 built artifacts.

The packed image lists inside the built ISO will be referenced in the final stage of Harvester upgrades to purge unneeded container images. If the image lists contain wrong image names, the container images cannot be removed.

In addition, future releases will publish the image lists with ARCH as the name suffix. We need to adapt this to prevent build failure.

To Reproduce
Steps to reproduce the behavior:

1. Build the v1.3.0-rc4 ISO image
2. Examine the built image, check the packed image list

Expected behavior

Fetch the correct image list according to the target architecture and pack them into the ISO image.

Support bundle

N/A

Environment

• Harvester ISO version: v1.3.0-rc4
• Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): not relevant

Additional context

N/A

[harvesterhci-io-github-bot]

Pre Ready-For-Testing Checklist

• If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
  The HEP PR is at:

• Where is the reproduce steps/test steps documented?
  The reproduce steps/test steps are at:

  1. arm64/amd64 iso should build up successfully.
  2. mount iso and check if v1.3.0/v1.3.1/v1.3.2 image-lists exist under {MOUNT_PATH}/bundle/harvester/images-lists-archive
     e.g. sudo mount -o loop ./harvester-v1.4.0-rc2-amd64.iso /mnt/iso_image, and check those image lists

➜ brandboat@suse  /mnt/iso_image/bundle/harvester/images-lists-archive  ls -la
total 26
drwxr-xr-x 1 root root 2048 Oct  9 17:56 .
drwxr-xr-x 1 root root 2048 Oct  9 17:56 ..
drwxr-xr-x 1 root root 2048 Oct  9 17:56 current
drwxr-xr-x 1 root root 2048 Oct  9 17:56 v1.1.0
drwxr-xr-x 1 root root 2048 Oct  9 17:56 v1.1.1
drwxr-xr-x 1 root root 2048 Oct  9 17:56 v1.1.2
drwxr-xr-x 1 root root 2048 Oct  9 17:56 v1.1.3
drwxr-xr-x 1 root root 2048 Oct  9 17:56 v1.2.0
drwxr-xr-x 1 root root 2048 Oct  9 17:56 v1.2.1
drwxr-xr-x 1 root root 2048 Oct  9 17:56 v1.2.2
drwxr-xr-x 1 root root 2048 Oct  9 17:56 v1.3.0
drwxr-xr-x 1 root root 2048 Oct  9 17:56 v1.3.1
drwxr-xr-x 1 root root 2048 Oct  9 17:56 v1.3.2

• Is there a workaround for the issue? If so, where is it documented?
  The workaround is at:

• Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
  The PR is at: Make image list packing architecture-awared harvester-installer#682

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

• If labeled: area/ui Has the UI issue filed or ready to be merged?
  The UI issue/PR is at:

• If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
  The documentation/KB PR is at:

• If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

  • The automation skeleton PR is at:
  • The automation test case PR is at:

• If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
  The compatibility issue is filed at:

[harvesterhci-io-github-bot]

Automation e2e test issue: harvester/tests#1185

[lanfon72]

milestone/release required.

[brandboat]

thanks @lanfon72 , milestone added, this one should be included in v1.4.0 and backport to v1.3 (it was merged, and I thought is in v1.3.1 release... harvester/harvester-installer#691)

[albinsun]

Test PASS, both AMD64 and ARM64 arch has image_list_all.txt for v1.3.0, v1.3.1 and v1.3.2, close as fixed.

Environment

• Harvester Image
  • harvester-v1.4.0-rc2-amd64.iso
  • harvester-v1.4.0-rc2-arm64.iso

Test Steps

1. Mount Harvester AMD64 and ARM64 ISOs

   

2. Check AMD64 v1.3.0, v1.3.1 and v1.3.2 image_list_all.txt exists

   

3. Check ARM v1.3.0, v1.3.1 and v1.3.2 image_list_all.txt exists