Make image list packing architecture-awared #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I created PRs to sync the upgrade matrix in the master and v1.3 branch: |
starbops
approved these changes
Mar 28, 2024
starbops
approved these changes
Mar 28, 2024
scripts/archive-images-lists.sh
Outdated
| curl -fL https://releases.rancher.com/harvester/"$prev_ver"/image-lists.tar.gz -o "$WORKING_DIR"/image-lists.tar.gz || ret=$? | ||
| image_lists_url=https://releases.rancher.com/harvester/"$prev_ver"/image-lists.tar.gz | ||
| # arch-aware image is available after v1.3.0 | ||
| if [ "$(version_compare "$prev_ver" "v1.3.0")" -eq "1" ]; then |
There was a problem hiding this comment.
Though it works, we usually use -eq to compare integers. It's better to follow the rules. Thank you.
There was a problem hiding this comment.
oops, yes it should be integer, my bad :(
|
@mergify backport v1.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
(cherry picked from commit 5daab04)
brandboat
added a commit
to brandboat/harvester-installer
that referenced
this pull request
Mar 29, 2024
bk201
pushed a commit
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The script archive-image-lists.sh lacks architecture awareness and could potentially lead to failures within our CI pipeline, particularly if newer versions (> 1.3.0) have been released.
Solution:
Compare the version in
upgrade-matrix.yamlwith v1.3.0, if version >= v1.3.0, which means that version already support different architecture images, and we need to download the image lists tarball fromhttps://releases.rancher.com/harvester/{VERSION}/image-lists-{ARCH}.tar.gz.Related Issue:
harvester/harvester#5313
Test plan:
git clone --branch HARV-5313 --single-branch --depth 1 https://github.com/brandboat/harvester-installer.git ../harvester-installermake build-isowithout errorAs you can see the console output shows that the script download v1.3.0 image list tarball with a specific architecture amd64, while others still use generic URL without architecture specification.
