Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix if condition in archive-images-lists.sh #690

Merged

Conversation

brandboat
Copy link
Contributor

@brandboat brandboat commented Mar 28, 2024

related to harvester/harvester#5313
this is a followup in #682

@brandboat brandboat force-pushed the chore/remove-quote-in-archive-image-lists branch from 7009f2b to 68670b6 Compare March 28, 2024 09:33
@brandboat brandboat changed the title Remove double quote in integer comparison condition Fix if condition in archive-images-lists.sh Mar 28, 2024
@brandboat brandboat requested a review from starbops March 28, 2024 10:13
Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@brandboat brandboat requested a review from bk201 March 29, 2024 03:00
@bk201 bk201 merged commit 2689ff5 into harvester:master Mar 29, 2024
5 checks passed
@brandboat brandboat deleted the chore/remove-quote-in-archive-image-lists branch March 29, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants