Remove implicit environ from storage #988
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has #987 as diffbase.
@tseaver The 2nd commit in this PR is all over the place. I can try to re-work if it seems too daunting.
It started out as just deleting
_implicit_environ
and then dealing with all the dependencies. This includedgcloud.get_default_project()
_client_or_connection
for_require_client
(and movingBucket._require_client
to_PropertyMixin
)connection
(from_client_or_connection
) to beclient.connection
client
properties toACL
and_PropertyMixin
methodsstorage._require_connection
methodbucket
required inBlob
constructorBucket.create
so that both the project and connection come from theclient