Skip to content

Remove implicit environ from storage #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhermes merged 2 commits into from
Jul 20, 2015
Merged

Remove implicit environ from storage #988

dhermes merged 2 commits into from
Jul 20, 2015

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Jul 14, 2015

Has #987 as diffbase.

@tseaver The 2nd commit in this PR is all over the place. I can try to re-work if it seems too daunting.

It started out as just deleting _implicit_environ and then dealing with all the dependencies. This included

  • ditching gcloud.get_default_project()
  • axing a lot of the implicit test utils
  • swapping the _client_or_connection for _require_client (and moving Bucket._require_client to _PropertyMixin)
  • updating uses of connection (from _client_or_connection) to be client.connection
  • adding client properties to ACL and _PropertyMixin methods
  • removing the storage._require_connection method
  • removing the concept of default bucket and making bucket required in Blob constructor
  • updating Bucket.create so that both the project and connection come from the client
  • removing lots of "implicit" tests that had explicit equivalents

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2015
@dhermes dhermes mentioned this pull request Jul 14, 2015
Merged
tseaver referenced this pull request in dhermes/google-cloud-python Jul 14, 2015
@dhermes
Making iterators accept client instead of connection.
30c94de
dhermes referenced this pull request in dhermes/google-cloud-python Jul 14, 2015
@dhermes
Removing _implicit_environ from storage.
e627eaa 
Towards googleapis#952.
@tseaver
Copy link
Contributor

tseaver commented Jul 20, 2015

@dhermes Do you plan to rebase here after #987 lands?

@dhermes dhermes force-pushed the remove-storage-implicit-environ branch from e627eaa to cc7af4e Compare July 20, 2015 20:15
@dhermes
Copy link
Contributor Author

dhermes commented Jul 20, 2015

@tseaver Rebased on top of #987

tseaver
tseaver reviewed Jul 20, 2015
View reviewed changes
gcloud/_testing.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Jul 20, 2015

LGTM

dhermes added a commit that referenced this pull request Jul 20, 2015
@dhermes
Merge pull request #988 from dhermes/remove-storage-implicit-environ
64ceff4 
Remove implicit environ from storage
@dhermes dhermes merged commit 64ceff4 into googleapis:master Jul 20, 2015
@dhermes dhermes deleted the remove-storage-implicit-environ branch July 20, 2015 21:10
@dhermes dhermes mentioned this pull request Jul 21, 2015
Merged
parthea pushed a commit that referenced this pull request Nov 24, 2025
@jameslynnwu
fix: add a separate DEFAULT_CLIENT_INFO for rest clients (#988)
f28888c
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please
chore: release 0.51.2 (#984)
13832b2 
🤖 I have created a release \*beep\* \*boop\*
---
### [0.51.2](https://www.github.com/googleapis/gapic-generator-python/compare/v0.51.1...v0.51.2) (2021-09-13)


### Bug Fixes

* add a separate DEFAULT_CLIENT_INFO for rest clients ([#988](https://www.github.com/googleapis/gapic-generator-python/issues/988)) ([22ac400](https://www.github.com/googleapis/gapic-generator-python/commit/22ac40097ab50bb2d3a7f1a2d35d659c391e0927))
* **snippetgen:** use f-strings in print statements ([#975](https://www.github.com/googleapis/gapic-generator-python/issues/975)) ([122e85c](https://www.github.com/googleapis/gapic-generator-python/commit/122e85c37ff6aa0a99f64361397eb3df5495a3b4))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Nov 24, 2025
@daniel-sanche @mgraczyk
feat: support not_equal queries for none and nan (#988)
35f65c0 
* feat: add IS_NOT_NULL operator to filters

* unit tests

* fixed lint

* refactored

* added NOT_NAN

* add system tests for != null and != nan

* updated system test

---------

Co-authored-by: Michael Graczyk <michael@mgraczyk.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
@gcf-owl-bot @arithmetic1728
feat: Pluggable auth support (#995)
97bde16 
* feat: Add Pluggable auth support (#988)

* Port identity pool credentials

* access_token retrieved

* -> pluggable

* Update pluggable.py

* Create test_pluggable.py

* Unit tests

* Address pr issues

* feat: Add file caching (#990)

* Add file cache

* feat: add output file cache support

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update pluggable.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update pluggable.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update setup.py

* Update setup.py

* Update setup.py

* pytest_subprocess

* timeout

* Update pluggable.py

* env

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update _default.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update requirements.txt

* Update _default.py

* Update pluggable.py

* Update pluggable.py

* Update pluggable.py

* Update test_pluggable.py

* format validations

* Update _default.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update requirements.txt

* Revert "Update requirements.txt"

This reverts commit 1c9b6db25c683663ed4b71ab0ab39946fce8f6eb.

* Revert "Update _default.py"

This reverts commit ac6c36072084a440c234a9465b35462bd52378b3.

* Revert "Revert "Update _default.py""

This reverts commit 1c08483586007e4caf1a36f2c9cbf2a45d403ee0.

* Raise output format error but retry parsing token if `success` is 0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update requirements.txt

* Delete test_pluggable.py

* Revert "Delete test_pluggable.py"

This reverts commit 74beba9405564a5b764af8718c49e640d9b84c5f.

* Update pluggable.py

* Update pluggable.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* pytest-subprocess

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* lint

* Update pluggable.py

* nox cover

nox cover

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* lint

* Update test_pluggable.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Update test_pluggable.py

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: arithmetic1728 <58957152+arithmetic1728@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
@gcf-owl-bot @arithmetic1728 @lsirac
feat: pluggable auth support (#1045)
4c8a5f9 
* feat: Add Pluggable auth support

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

feat: Add Pluggable auth support (#988)

* Port identity pool credentials

* access_token retrieved

* -> pluggable

* Update pluggable.py

* Create test_pluggable.py

* Unit tests

* Address pr issues

feat: Add file caching (#990)

* Add file cache

* feat: add output file cache support

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Update pluggable.py

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Update pluggable.py

Update setup.py

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Update setup.py

Update setup.py

pytest_subprocess

timeout

Update pluggable.py

env

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Update _default.py

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Update requirements.txt

Update _default.py

Update pluggable.py

Update pluggable.py

Update pluggable.py

Update test_pluggable.py

format validations

Update _default.py

Update requirements.txt

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Revert "Update requirements.txt"

This reverts commit 1c9b6db25c683663ed4b71ab0ab39946fce8f6eb.

Revert "Update _default.py"

This reverts commit ac6c36072084a440c234a9465b35462bd52378b3.

Revert "Revert "Update _default.py""

This reverts commit 1c08483586007e4caf1a36f2c9cbf2a45d403ee0.

Raise output format error but retry parsing token if `success` is 0

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Update requirements.txt

Delete test_pluggable.py

Revert "Delete test_pluggable.py"

This reverts commit 74beba9405564a5b764af8718c49e640d9b84c5f.

Update pluggable.py

Update pluggable.py

pytest-subprocess

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

lint

Update pluggable.py

nox cover

nox cover

🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

lint

Update test_pluggable.py

Update test_pluggable.py

* Disable Pluggable Auth for Python 2.*

Update noxfile.py

* Update pluggable.py

* Update pluggable.py

* Update pluggable.py

* Update pluggable.py

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Address PR issues

* Update pluggable.py

* Update pluggable.py

* Update user-guide.rst

* Update user-guide.rst

* Update user-guide.rst

* Update user-guide.rst

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: arithmetic1728 <58957152+arithmetic1728@users.noreply.github.com>
Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes @tseaver @googlebot