Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace optional connection with client in storage methods and functions. #984

Merged
merged 11 commits into from
Jul 14, 2015
Merged

Replace optional connection with client in storage methods and functions. #984

merged 11 commits into from
Jul 14, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jul 13, 2015

Towards #952.

Did this for all but Bucket.create (since it also requires a project, built for just a client)

Will continue to remove connection from the Bucket and Batch constructors in forthcoming PR.

@dhermes
Updating Blob.generate_signed_url to accept a client.
872a101 
Towards googleapis#952, removing connection from methods / constructors.
@dhermes
Updating Blob.exists to accept a client.
3905a5b 
Towards googleapis#952, removing connection from methods / constructors.
@dhermes
Updating Blob.download* methods to accept a client.
301bc1c 
Towards googleapis#952, removing connection from methods / constructors.

Also adding a temporary Blob._client_or_connection method
to allow switching from an explicit client to an implicit
connection.
@dhermes
Updating Blob.upload* and Bucket.upload* methods to accept a client.
83590a1 
Towards googleapis#952, removing connection from methods / constructors.
@dhermes
Updating Bucket.exists method to accept a client.
78b1d83 
Towards googleapis#952, removing connection from methods / constructors.

Also adding a temporary Bucket._client_or_connection method
to allow switching from an explicit client to an implicit
connection.
@dhermes
Updating Bucket.get_blob method to accept a client.
c012b31 
Towards googleapis#952, removing connection from methods / constructors.
@dhermes
Updating Bucket.copy_blob and Blob.rename methods to accept a client.
c30132b 
Towards googleapis#952, removing connection from methods / constructors.
@dhermes
Updating delete methods on Blob and Bucket to accept a client.
3c9b7e3 
Towards googleapis#952, removing connection from methods / constructors.
@dhermes
Updating Bucket.make_public and ACL.reload accept a client.
c309d0c 
Towards googleapis#952, removing connection from methods / constructors.
@dhermes
Updating storage.ACL methods to accept a client.
adb0bc1 
Also updating all code which calls those methods.

Towards googleapis#952, removing connection from methods / constructors.
@dhermes
Updating patch() and reload() storage methods to accept a client.
586274a 
Towards googleapis#952, removing connection from methods / constructors.
@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Jul 13, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 13, 2015
@dhermes dhermes mentioned this pull request Jul 13, 2015
Closed
7 tasks
@tseaver
Copy link
Contributor

tseaver commented Jul 13, 2015

Hmm, before finishing review here, it feels to me like swapping out the connection=None for client=None is premature: shouldn't we establish a client attribute, so that we can fall back to using it? Otherwise we have to revisit all these methods when we do have the client attribute.

@dhermes
Copy link
Contributor Author

dhermes commented Jul 13, 2015

I just wanted to make a bunch of small commits so review was easier for you. I have the client attribute at the ready, it just takes a bit more effort to review (it reaches deep into many parts of the code).

@dhermes
Copy link
Contributor Author

dhermes commented Jul 13, 2015

@tseaver Can we push forward on this? I want to wrap up the client stuff and cut a release ASAP.

@dhermes dhermes mentioned this pull request Jul 13, 2015
Merged
@tseaver
Copy link
Contributor

tseaver commented Jul 14, 2015

LGTM

@dhermes
Copy link
Contributor Author

dhermes commented Jul 14, 2015

@tseaver We've got an LGTM here but a few pending commets. Good to merge?

@dhermes
Copy link
Contributor Author

dhermes commented Jul 14, 2015

Oh I'm sorry 8b1ecb2 was in #987. Merging and will rebase that.

dhermes added a commit that referenced this pull request Jul 14, 2015
@dhermes
Merge pull request #984 from dhermes/replace-connection-in-storage
247899b 
Replace optional connection with client in storage methods and functions.
@dhermes dhermes merged commit 247899b into googleapis:master Jul 14, 2015
@dhermes dhermes deleted the replace-connection-in-storage branch July 14, 2015 14:54
@dhermes dhermes mentioned this pull request Jul 21, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @tseaver @googlebot