Skip to content

Making iterators accept client instead of connection. #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jul 14, 2015

Has #988 as diffbase

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Jul 14, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2015
@tseaver
Copy link
Contributor

tseaver commented Jul 20, 2015

@dhermes ping me after #988 lands (a rebase would help review).

@dhermes
Copy link
Contributor Author

dhermes commented Jul 20, 2015

Looks like I've got some work to make it merge, will hold off until #988 is in before re-basing.

@dhermes dhermes force-pushed the storage-make-iterator-accept-client branch from 30c94de to 99e9f31 Compare July 20, 2015 21:11
@dhermes
Copy link
Contributor Author

dhermes commented Jul 20, 2015

@tseaver I rebased.

@tseaver
Copy link
Contributor

tseaver commented Jul 20, 2015

LGTM

dhermes added a commit that referenced this pull request Jul 20, 2015
Making iterators accept client instead of connection.
@dhermes dhermes merged commit de58acb into googleapis:master Jul 20, 2015
@dhermes dhermes deleted the storage-make-iterator-accept-client branch July 20, 2015 21:22
@dhermes dhermes mentioned this pull request Jul 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants