Replace connection in bucket constructor. #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This was referenced Jul 13, 2015
Towards googleapis#952, removing connection from methods / constructors.
Towards googleapis#952. Introduced temporary hack to allow system-tests to continue passing. Implicit environment has still not been completely removed.
dhermes
force-pushed
the
replace-connection-in-bucket
branch
from
8b1ecb2 to
017346a
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@tseaver Any remaining issues? |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
We can merge this one to get to the next. |
dhermes
added a commit
that referenced
this pull request
Jul 20, 2015
Replace connection in bucket constructor.
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
gcf-owl-bot bot
added a commit
that referenced
this pull request
Mar 13, 2025
Source-Link: googleapis/googleapis@2753fe1 Source-Link: googleapis/googleapis-gen@8472eeb Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6Ijg0NzJlZWJhYTIxMDNjYjFlMjc4NmViMTFlMzQ2NGRkNWVhNzQyMjMifQ==
vchudnov-g
pushed a commit
that referenced
this pull request
Mar 14, 2025
…250302 (#987) (#13656) - [ ] Regenerate this pull request now. Source-Link: googleapis/googleapis@2753fe1 Source-Link: googleapis/googleapis-gen@8472eeb Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6Ijg0NzJlZWJhYTIxMDNjYjFlMjc4NmViMTFlMzQ2NGRkNWVhNzQyMjMifQ== --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
* feat: add support for context manager in client. * chore: remove extra whitespace. * chore: adds autogenerated unit tests. * chore: adds stronger warning. * chore: fixes tests. * chore: adds auto-generated tests for ads. * chore: updates golden files. * chore: refactor. * chore: refactor. * feat: adds close() to transport and ctx to async client. * feat: adds close method and removes ctx from transport in ads. * chore: adds warning infobox to docstring. * chore: updates integration tests. * chore: fixes typo.
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
…#1053) * feat!: Support SQLAlchemy 2.0, drop support for 1.x This patch makes this library backward incompatible for versions of SQLAlchemy < 2.0. Fixes #510 * constraints updated * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fixing README.rst * fixing README.rst * upping sqlalchemy version in constraints-3.8.txt * adding 2.0 version restrictions to owlbot.py * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix for * Updated some compliance tests for sqla2 and bq * Addressed snippet errors * revert bad commit * More compliance tests checking * reformatted with black * Changed more compliance tests, updated requirements for testing * Fixed attributeerror in failing sample test * Fixed geolography test failing issue * Minor tweaks to tests and code * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Fixed small error in compliance tests, added pip freeze for owl bot testing * Fixed some failing compliance tests by reformatting * Added UuidTest to compliance tests * Moved back sqlalchemy constraints to 1.4 * Update testing/constraints-3.8.txt * Fixed minimum version of sqlalchemy for 1.4 backwards compatibility * Bumping support for sqlalchemy 1.4.16 for sample tests * Bump setup.py sqlalchemy to 1.4.16 * Updated compliance sqlalchemy to 1.4.16 * Fixed broken code in last merged main, as we need to avoid duplicate entries and potential implicit joins due to identical table names * modified tests for join order variation in 1.4 vs 2.0 * typo * Modified one compliance StringTest thats been flaky * Updated docs * minor fixes to noxfile and README * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * cleaned up code from review, removed unnecessary code and files * Update tests/sqlalchemy_dialect_compliance/test_dialect_compliance.py * create development release 1.11.0.dev0 branch * chore: cleanup compliance tests for sqlalchemy migration (#1013) * chore: remove code for sqlalchemy before 1_4 * reformatted with black: * Removed sqlalchemy compliance tests from versions before 1.4 * removed code in base.py for sqlalchemy < 1.4 * fix coverage issues in base.py * temporarily commented out code lines not passing coverage for testing purposes * replaced functions previously removed for not passing cover * testing removing functions for coverage * add no cover tag to untested code and clean up commented out functions * fix lint issues * black * chore: cleanup compliance file tests after migration * lint * fixed small import error --------- Co-authored-by: Sharoon Thomas <sharoon.thomas@fulfil.io> * Revert "chore: cleanup compliance tests for sqlalchemy migration" (#1015) * chore: fix coverage tests sqlalchemy 2.0 migration (#987) * chore: remove code for sqlalchemy before 1_4 * reformatted with black: * Removed sqlalchemy compliance tests from versions before 1.4 * removed code in base.py for sqlalchemy < 1.4 * fix coverage issues in base.py * temporarily commented out code lines not passing coverage for testing purposes * replaced functions previously removed for not passing cover * testing removing functions for coverage * add no cover tag to untested code and clean up commented out functions * fix lint issues * black * Readded deleted tests and renamed them from deprecated names * black --------- Co-authored-by: Sharoon Thomas <sharoon.thomas@fulfil.io> * chore: sqlalchemy test compliance suite cleanup (#1018) * chore: remove code for sqlalchemy before 1_4 * reformatted with black: * Removed sqlalchemy compliance tests from versions before 1.4 * removed code in base.py for sqlalchemy < 1.4 * fix coverage issues in base.py * temporarily commented out code lines not passing coverage for testing purposes * replaced functions previously removed for not passing cover * testing removing functions for coverage * add no cover tag to untested code and clean up commented out functions * fix lint issues * black * Readded deleted tests and renamed them from deprecated names * black * chore: sqlalchemy test compliance suite cleanup code * black * black --------- Co-authored-by: Sharoon Thomas <sharoon.thomas@fulfil.io> * create development release 1.11.0.dev1 branch * feat: grouping sets, rollup and cube compatibility * create development release 1.11.0.dev2 * test commit to run kokooro tests * removed unnecessary clause function changes, edited tests * test basic implementation of group_by_clause and visit_label * fixed render label as label assignment * added test case * reformat logic * test commit * create development build 1.11.0.dev3 * chore: add more grouping sets/rollup/cube tests (#1029) * chore: add more tests for grouping functions fix * reformatted tests * update changelog * revert changelog * remove note * don't install prerelease in compliance session * sync owlbot * Update tests/sqlalchemy_dialect_compliance/test_dialect_compliance.py * make results order not matter * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Sharoon Thomas <sharoon.thomas@fulfil.io> Co-authored-by: Nishant Nayak <nishantnayak@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: kiraksi <kirnendra@google.com> Co-authored-by: Chalmer Lowe <chalmerlowe@google.com> Co-authored-by: Chalmer Lowe <chalmer.lowe@gmail.com> Co-authored-by: Kira <kira.kaur.sidhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has #984 as diffbase.
Also updating storage.Batch to accept a client.
Introduced temporary hack to allow system-tests to continue passing. Implicit environment has still not been completely removed.