Skip to content

Flesh out pubsub topics #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 19, 2015
Merged

Flesh out pubsub topics #742

merged 10 commits into from
Mar 19, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 18, 2015

Following #691.

  • Updates the API docs slightly (making batching explicit).
  • Adds a connection lifted from gcloud.storage.connection.
  • Adds Topic class and list_topics API function.

Does not handle implicit connection / project ID stuff (which should be shared, as called for in #741).

tseaver added 4 commits March 18, 2015 10:24
@tseaver
Sketch 'gcloud.pubsub' API.
7deb85b
@tseaver
Add 'pubsub.connection.Connection'
832b98f 
Copied from 'storage.connection.Connection', with storage-specific bits
(e.g., upload) removed.
@tseaver
Add 'pubsub.topic.Topic' class.
fd69e33 
Include 'create', 'delete', 'exists', and 'publish' methods.

Inclue 'pubsub.topic.Topic.batch', which allows publishing multiple messages
to a topic as a single API request.
@tseaver
Add 'pubsub.api.list_topics'.
3b5fa86
@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Mar 18, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2015
This was referenced Mar 18, 2015
Closed
Closed
dhermes
dhermes reviewed Mar 18, 2015
View reviewed changes
docs/pubsub-api.rst

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This was referenced Mar 18, 2015
Merged
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cf8b9fa on tseaver:691-flesh_out_pubsub_topics into aa684be on GoogleCloudPlatform:master.

dhermes
dhermes reviewed Mar 18, 2015
View reviewed changes
gcloud/pubsub/api.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes
dhermes reviewed Mar 18, 2015
View reviewed changes
gcloud/pubsub/api.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9cd9cf6 on tseaver:691-flesh_out_pubsub_topics into aa684be on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 703d56b on tseaver:691-flesh_out_pubsub_topics into aa684be on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor Author

tseaver commented Mar 19, 2015

@dhermes, any remaining issues? I could merge here and then you could work on refactoring the connection stuff.

@dhermes
Copy link
Contributor

dhermes commented Mar 19, 2015

LGTM

tseaver added a commit that referenced this pull request Mar 19, 2015
@tseaver
Merge pull request #742 from tseaver/691-flesh_out_pubsub_topics
01d697e 
Flesh out pubsub topics
@tseaver tseaver merged commit 01d697e into googleapis:master Mar 19, 2015
@tseaver tseaver deleted the 691-flesh_out_pubsub_topics branch March 19, 2015 17:26
@dhermes dhermes mentioned this pull request Mar 19, 2015
Merged
@dhermes dhermes mentioned this pull request Mar 31, 2015
Merged
@dhermes dhermes mentioned this pull request Apr 9, 2015
Merged
parthea pushed a commit that referenced this pull request Aug 21, 2025
@gcf-owl-bot @Linchin
build(deps): bump cryptography from 41.0.6 to 42.0.0 in /synthtool/gc…
e801d1f 
…p/templates/python_library/.kokoro (#742)

Source-Link: googleapis/synthtool@e13b22b
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:97b671488ad548ef783a452a9e1276ac10f144d5ae56d98cc4bf77ba504082b4

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
@gcf-owl-bot @Linchin @parthea
build(deps): bump cryptography from 41.0.6 to 42.0.0 in /synthtool/gc…
597fa22 
…p/templates/python_library/.kokoro (#742)

Source-Link: googleapis/synthtool@e13b22b
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:97b671488ad548ef783a452a9e1276ac10f144d5ae56d98cc4bf77ba504082b4

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @coveralls @dhermes @googlebot