Skip to content

Commit 9cd9cf6

Browse files
committed
Delete messages from batch after successful commit API return.
Addresses: https://github.com/GoogleCloudPlatform/gcloud-python/pull/742/files#r26701080
1 parent 301ea73 commit 9cd9cf6

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

gcloud/pubsub/test_topic.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ def test_publish_multiple(self):
149149
batch.publish(PAYLOAD1)
150150
batch.publish(PAYLOAD2, attr1='value1', attr2='value2')
151151
self.assertEqual(list(batch), [MSGID1, MSGID2])
152+
self.assertEqual(list(batch.messages), [])
152153
self.assertEqual(len(conn._requested), 1)
153154
req = conn._requested[0]
154155
self.assertEqual(req['method'], 'POST')

gcloud/pubsub/topic.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,5 +145,6 @@ def commit(self):
145145
conn = self.topic.connection
146146
response = conn.api_request(method='POST',
147147
path='%s:publish' % self.topic.path,
148-
data={'messages': self.messages})
148+
data={'messages': self.messages[:]})
149149
self.message_ids.extend(response['messageIds'])
150+
del self.messages[:]

0 commit comments

Comments
 (0)