Skip to content

Commit 703d56b

Browse files
committed
Don't bend over backward to avoid passing empty .
Addresses: #742 (comment)
1 parent 9cd9cf6 commit 703d56b

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

gcloud/pubsub/api.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,4 @@ def list_topics(page_size=None, page_token=None,
5151
params['pageToken'] = page_token
5252

5353
path = '/projects/%s/topics' % project
54-
if params:
55-
return connection.api_request(method='GET', path=path,
56-
query_params=params)
57-
return connection.api_request(method='GET', path=path)
54+
return connection.api_request(method='GET', path=path, query_params=params)

gcloud/pubsub/test_api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def test_w_explicit_connection_no_paging(self):
3737
req = conn._requested[0]
3838
self.assertEqual(req['method'], 'GET')
3939
self.assertEqual(req['path'], '/projects/%s/topics' % PROJECT)
40-
self.assertEqual(req.get('query_params'), None)
40+
self.assertEqual(req['query_params'], {})
4141

4242
def test_w_explicit_connection_w_paging(self):
4343
TOPIC_NAME = 'topic_name'

0 commit comments

Comments
 (0)