Skip to content

Comments

feat: GSoC 2025 Contributions - Core Updates & Optimizations#1454

Open
SH20RAJ wants to merge 1 commit intogoogle-deepmind:masterfrom
SH20RAJ:feat/gsoc-2025-contributions
Open

feat: GSoC 2025 Contributions - Core Updates & Optimizations#1454
SH20RAJ wants to merge 1 commit intogoogle-deepmind:masterfrom
SH20RAJ:feat/gsoc-2025-contributions

Conversation

@SH20RAJ
Copy link
Contributor

@SH20RAJ SH20RAJ commented Jan 22, 2026

This PR consolidates my initial contributions for GSoC 2025 (Core Updates & Optimizations).

Fixes & Optimizations

Verified with kuhn_consistency_test and euchre_test.

(Removed Crazyhouse implementation as requested, as it is tracked in a separate PR)

@SH20RAJ SH20RAJ force-pushed the feat/gsoc-2025-contributions branch from 3e69063 to 66aad20 Compare January 22, 2026 11:36
@lanctot
Copy link
Collaborator

lanctot commented Jan 22, 2026

@SH20RAJ please don't cascade the contributions across PRs.

The crazyhouse implementation is in a separate PR, please remove it from this one and rename the PR accordingly.

Thanks!

@SH20RAJ SH20RAJ force-pushed the feat/gsoc-2025-contributions branch from 66aad20 to 9fdc37e Compare January 30, 2026 04:31
Includes:
- Optimization: Euchre computation simplification (Issue google-deepmind#3)
- Bug Fix: Phantom TTT history tracking (Issue #1)
- Bug Fix: Universal Poker action count logic clarification (Issue google-deepmind#4)
- Bug Fix: Standardize Kuhn Poker observation strings (Issue google-deepmind#5)
- Doc: Updated Go/PhantomGo URLs (Issue google-deepmind#2)
@SH20RAJ SH20RAJ force-pushed the feat/gsoc-2025-contributions branch from 9fdc37e to 9fb3d05 Compare January 30, 2026 04:31
@SH20RAJ SH20RAJ changed the title GSoC 2025 Contributions: Crazyhouse Chess, Euchre Optimization, & Cor… feat: GSoC 2025 Contributions - Core Updates & Optimizations Jan 30, 2026
@SH20RAJ
Copy link
Contributor Author

SH20RAJ commented Jan 30, 2026

@lanctot I have removed the Crazyhouse implementation from this PR as requested. It now only contains the core updates and optimizations for Kuhn Poker, Euchre, Universal Poker, Phantom TTT, and Documentation.

I verified the changes and force-pushed. Please let me know if anything else needs adjustment.

@lanctot
Copy link
Collaborator

lanctot commented Feb 15, 2026

Hi @SH20RAJ,

The quoted issues are from more than 6 years ago. Any reason you're applying fixes based on 6 year-old issues that were closed long ago?

I think I would rather keep the files as they are now.. this would introduce some backward-incompatibilities that seem like they're worth the effort.

@SH20RAJ
Copy link
Contributor Author

SH20RAJ commented Feb 23, 2026

Hi @lanctot, I understand! I was initially going through some of the older closed issues to find small entry-level tasks to get familiar with the codebase and architecture as part of my preparation for GSoC 2025. I didn't realize they might introduce backward incompatibilities. I'll focus my efforts on more recent and open issues going forward. Feel free to close this PR if these changes aren't needed or if you prefer keeping the files as they are. Thanks for the guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants