feat: GSoC 2025 Contributions - Core Updates & Optimizations#1454
feat: GSoC 2025 Contributions - Core Updates & Optimizations#1454SH20RAJ wants to merge 1 commit intogoogle-deepmind:masterfrom
Conversation
3e69063 to
66aad20
Compare
|
@SH20RAJ please don't cascade the contributions across PRs. The crazyhouse implementation is in a separate PR, please remove it from this one and rename the PR accordingly. Thanks! |
66aad20 to
9fdc37e
Compare
Includes: - Optimization: Euchre computation simplification (Issue google-deepmind#3) - Bug Fix: Phantom TTT history tracking (Issue #1) - Bug Fix: Universal Poker action count logic clarification (Issue google-deepmind#4) - Bug Fix: Standardize Kuhn Poker observation strings (Issue google-deepmind#5) - Doc: Updated Go/PhantomGo URLs (Issue google-deepmind#2)
9fdc37e to
9fb3d05
Compare
|
@lanctot I have removed the Crazyhouse implementation from this PR as requested. It now only contains the core updates and optimizations for Kuhn Poker, Euchre, Universal Poker, Phantom TTT, and Documentation. I verified the changes and force-pushed. Please let me know if anything else needs adjustment. |
|
Hi @SH20RAJ, The quoted issues are from more than 6 years ago. Any reason you're applying fixes based on 6 year-old issues that were closed long ago? I think I would rather keep the files as they are now.. this would introduce some backward-incompatibilities that seem like they're worth the effort. |
|
Hi @lanctot, I understand! I was initially going through some of the older closed issues to find small entry-level tasks to get familiar with the codebase and architecture as part of my preparation for GSoC 2025. I didn't realize they might introduce backward incompatibilities. I'll focus my efforts on more recent and open issues going forward. Feel free to close this PR if these changes aren't needed or if you prefer keeping the files as they are. Thanks for the guidance! |
This PR consolidates my initial contributions for GSoC 2025 (Core Updates & Optimizations).
Fixes & Optimizations
'b'/'p'), resolving internal inconsistencies (Issue Cool work. Do you plan to support large games, such as Texas Hold'em? #5).Trick::Playlogic for better readability and performance (Issue add_subdirectory given source "abseil-cpp" which is not existing #3).history_(Issue Public states support #1).nprocalias #2).Verified with
kuhn_consistency_testandeuchre_test.(Removed Crazyhouse implementation as requested, as it is tracked in a separate PR)