Open
Conversation
- Added MaxGameStringLength to Game class in spiel.h - Exposed in python bindings (pyspiel.cc) - Implemented for Kuhn Poker - Fixed compilation errors in spiel.h and bridge.cc (MutexLock) - Added unit test
SH20RAJ
added a commit
that referenced
this pull request
Jan 30, 2026
Includes: - Optimization: Euchre computation simplification (Issue google-deepmind#3) - Bug Fix: Phantom TTT history tracking (Issue #1) - Bug Fix: Universal Poker action count logic clarification (Issue google-deepmind#4) - Bug Fix: Standardize Kuhn Poker observation strings (Issue google-deepmind#5) - Doc: Updated Go/PhantomGo URLs (Issue google-deepmind#2)
SH20RAJ
added a commit
that referenced
this pull request
Jan 30, 2026
Includes: - Optimization: Euchre computation simplification (Issue google-deepmind#3) - Bug Fix: Phantom TTT history tracking (Issue #1) - Bug Fix: Universal Poker action count logic clarification (Issue google-deepmind#4) - Bug Fix: Standardize Kuhn Poker observation strings (Issue google-deepmind#5) - Doc: Updated Go/PhantomGo URLs (Issue google-deepmind#2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
MaxGameStringLengthAPI as requested in Issue google-deepmind#1452.Changes
virtual int MaxGameStringLength() const { return 0; }to theGameclass inopen_spiel/spiel.h.max_game_string_lengthinopen_spiel/python/pybind11/pyspiel.cc.MaxGameStringLengthforKuhnGame(Kuhn Poker).absl::MutexLockusage inspiel.handbridge.ccwhere the mutex address was missing.open_spiel/python/tests/max_game_string_length_test.pyto verify the implementation.Verification
Ran the new unit test: