add_subdirectory given source "abseil-cpp" which is not existing

[bradhowes]

Running (patched -- see #2) ./open_spiel/scripts/build_and_run_tests.sh per install instructions results in the following:

++ CXX=g++
++ NPROC=nproc
++ [[ darwin18 == \d\a\r\w\i\n* ]]
++ NPROC='sysctl -n hw.physicalcpu'
++ CXX=/usr/local/bin/g++-7
+++ sysctl -n hw.physicalcpu
++ MAKE_NUM_PROCS=4
++ let 'TEST_NUM_PROCS=4*4'
+++ python3 -c 'import sys; print(sys.version.split(" ")[0])'
++ PYVERSION=3.6.5
+++ python3 -c 'import sys; print(sys.version_info.major)'
++ PY_VERSION_MAJOR=3
++ BUILD_DIR=build_python_3
++ mkdir -p build_python_3
++ cd build_python_3
/Users/howes/src/open_spiel/build_python_3
++ echo 'Building and testing in /Users/howes/src/open_spiel/build_python_3 using '\''python'\'' (version 3.6.5).'
Building and testing in /Users/howes/src/open_spiel/build_python_3 using 'python' (version 3.6.5).
++ cmake -DPython_TARGET_VERSION=3.6.5 -DCMAKE_CXX_COMPILER=/usr/local/bin/g++-7 ../open_spiel
-- The C compiler identification is AppleClang 10.0.1.10010046
-- The CXX compiler identification is GNU 7.4.0
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Checking whether CXX compiler has -isysroot
-- Checking whether CXX compiler has -isysroot - yes
-- Checking whether CXX compiler supports OSX deployment target flag
-- Checking whether CXX compiler supports OSX deployment target flag - yes
-- Check for working CXX compiler: /usr/local/bin/g++-7
-- Check for working CXX compiler: /usr/local/bin/g++-7 -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:45 (add_subdirectory):
  add_subdirectory given source "abseil-cpp" which is not an existing
  directory.


-- Found Python3: /usr/local/opt/python/Frameworks/Python.framework/Versions/3.6/lib/libpython3.6m.dylib (found version "3.6.5") found components:  Development 
-- Configuring incomplete, errors occurred!
See also "/Users/howes/src/open_spiel/build_python_3/CMakeFiles/CMakeOutput.log".

[finbarrtimbers]

Did you run install.sh? If you did, what happens when you run ls in the root open_spiel directory?

[bradhowes]

Yes, I ran install.sh. Looking at it and its output, I see that it stops because Python3 is already installed, but not at the latest version. I see now the other dependencies. This allowed me to move on:

diff --git a/install.sh b/install.sh
index 8a1e50a..6c3e8f1 100755
--- a/install.sh
+++ b/install.sh
@@ -28,7 +28,8 @@ if [[ "$OSTYPE" == "linux-gnu" ]]; then
     sudo update-alternatives --install /usr/bin/python3 python3 /usr/bin/python${OS_PYTHON_VERSION} 10
   fi
 elif [[ "$OSTYPE" == "darwin"* ]]; then  # Mac OSX
-  brew install python3 gcc@7
+  brew install python3 || echo "** Warning: failed 'brew install python3'"
+  brew install gcc@7
   curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py
   python3 get-pip.py
   pip3 install virtualenv

[tranhoangkhuongvn]

Hi @bradhowes ,

I got same error at add_subdirectory given source "abseil-cpp" which is not an existing directory.
I modified my install.sh as suggested above then I ran again install.sh and it said there is Error at gcc@7 7.4.0 is already installed, to upgrade to 7.4.0_2 run brew upgrade gcc@7
Any suggestion to fix it?

I literally followed your issue until here and I installed this on latest MacOS
Many thanks

[lanctot]

Hi, I think this is because the install.sh script might have exited early.

At the bottom of the install script there are some git clone commands and my guess is that they did not execute, hence the abseil repos was not cloned and the directory is missing.

Can you tell us if the directory is indeed there?

Also @tranhoangkhuongvn, if you manage to successfully install on MacOS we would love to hear about it! :)

[tranhoangkhuongvn]

You're right, I commented out that line of installing gcc@7 because it's already installed and it can finish the install.sh script. However when I build and run CXX=g++ cmake -DPython_TARGET_VERSION=3.6 -DCMAKE_CXX_COMPILER=${CXX} ../open_spiel it has an error at
`Looking for pthread.h
Looking for pthread.h - found
Looking for pthread_create
Looking for pthread_create - found
Found Threads: TRUE
CMake Error at python/CMakeLists.txt:1 (if):
if given arguments:

"STREQUAL" ""
Unknown arguments specified
-- Configuring incomplete, errors occured!`

[lanctot]

Can you try two things:

Remove the ${CXX} and use g++ directly in the CMAKE_CXX_COMPILER:

1. CXX=g++ cmake -DPython_TARGET_VERSION=3.6 -DCMAKE_CXX_COMPILER=g++ ../open_spiel
2. Remove the CMakeCache.txt (if there is one) and rm -rf CMakeFiles

If 1 does not work, can you try 2 and then repeat 1?

[lanctot]

I ran into a similar issue on Debian 10 and Ubuntu 19.04, and I think the build_and_run_tests.sh gets it right by defining CXX=g++ at the top of the scripts and then not prefixing the command with CXX=g++. So I'd be also curious what happens when you run the build_and_run_tests.sh script in step 3 of the install guide ( https://github.com/deepmind/open_spiel/blob/master/docs/install.md )

[tranhoangkhuongvn]

Can you try two things:

Remove the ${CXX} and use g++ directly in the CMAKE_CXX_COMPILER:

1. CXX=g++ cmake -DPython_TARGET_VERSION=3.6 -DCMAKE_CXX_COMPILER=g++ ../open_spiel
2. Remove the CMakeCache.txt (if there is one) and rm -rf CMakeFiles

If 1 does not work, can you try 2 and then repeat 1?

Hi, I tried 1 and it went well without any error:

• The C compiler identification is AppleClang 10.0.1.10010046
  -- The CXX compiler identification is AppleClang 10.0.1.10010046
  -- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
  -- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- Check for working CXX compiler: /usr/bin/g++
  -- Check for working CXX compiler: /usr/bin/g++ -- works
  -- Detecting CXX compiler ABI info
  -- Detecting CXX compiler ABI info - done
  -- Detecting CXX compile features
  -- Detecting CXX compile features - done
  -- Looking for pthread.h
  -- Looking for pthread.h - found
  -- Looking for pthread_create
  -- Looking for pthread_create - found
  -- Found Threads: TRUE
  -- Found Python3: /usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/lib/libpython3.7m.dylib (found version "3.7.4") found components: Development
  -- Configuring done
  -- Generating done
  -- Build files have been written to: /Users/khuongtran/Documents/fun_learning/AI/open_spiel/build

I ran again the build_and_run_test script and it still stuck at the same error, here is the log for your reference:
++ CXX=g++
++ NPROC=nproc
++ [[ darwin18 == \d\a\r\w\i\n* ]]
++ NPROC='sysctl -n hw.physicalcpu'
++ CXX=/usr/local/bin/g++-7
+++ sysctl -n hw.physicalcpu
++ MAKE_NUM_PROCS=6
++ let 'TEST_NUM_PROCS=4*6'
+++ python3 -c 'import sys; print(sys.version.split(" ")[0])'
++ PYVERSION=3.6.9
+++ python3 -c 'import sys; print(sys.version_info.major)'
++ PY_VERSION_MAJOR=3
++ BUILD_DIR=build_python_3
++ mkdir -p build_python_3
++ cd build_python_3
++ echo 'Building and testing in /Users/khuongtran/Documents/fun_learning/AI/open_spiel/build_python_3 using '''python''' (version 3.6.9).'
Building and testing in /Users/khuongtran/Documents/fun_learning/AI/open_spiel/build_python_3 using 'python' (version 3.6.9).
++ cmake -DPython_TARGET_VERSION=3.6.9 -DCMAKE_CXX_COMPILER=/usr/local/bin/g++-7 ../open_spiel
-- The C compiler identification is AppleClang 10.0.1.10010046
-- The CXX compiler identification is GNU 7.4.0
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Checking whether CXX compiler has -isysroot
-- Checking whether CXX compiler has -isysroot - yes
-- Checking whether CXX compiler supports OSX deployment target flag
-- Checking whether CXX compiler supports OSX deployment target flag - yes
-- Check for working CXX compiler: /usr/local/bin/g++-7
-- Check for working CXX compiler: /usr/local/bin/g++-7 -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE
-- Found Python3: /usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/lib/libpython3.7m.dylib (found version "3.7.4") found components: Development
-- Configuring done
You have changed variables that require your cache to be deleted.
Configure will be re-run and you may have to reset some variables.
The following variables have changed:
CMAKE_CXX_COMPILER= /usr/local/bin/g++-7

-- The C compiler identification is AppleClang 10.0.1.10010046
-- The CXX compiler identification is GNU 7.4.0
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Checking whether CXX compiler has -isysroot
-- Checking whether CXX compiler has -isysroot - yes
-- Checking whether CXX compiler supports OSX deployment target flag
-- Checking whether CXX compiler supports OSX deployment target flag - yes
-- Check for working CXX compiler: /usr/local/bin/g++-7
-- Check for working CXX compiler: /usr/local/bin/g++-7 -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE
CMake Error at python/CMakeLists.txt:1 (if):
if given arguments:

"STREQUAL" ""

Unknown arguments specified

-- Configuring incomplete, errors occurred!
See also "/Users/khuongtran/Documents/fun_learning/AI/open_spiel/build_python_3/CMakeFiles/CMakeOutput.log".
You have changed variables that require your cache to be deleted.
Configure will be re-run and you may have to reset some variables.
The following variables have changed:
CMAKE_CXX_COMPILER= /usr/local/bin/g++-7

-- Generating done
-- Build files have been written to: /Users/khuongtran/Documents/fun_learning/AI/open_spiel/build_python_3

[lanctot]

If 1 worked without an error, then you should be able to move on to building OpenSpiel.

My suggestion now is then:

in your build/ directory:

rm -rf CMakeCache.txt CMakeFiles # remove the cmake meta files
CXX=g++ cmake -DPython_TARGET_VERSION=3.6 -DCMAKE_CXX_COMPILER=g++ ../open_spiel
make -j12
ctest -j12

[tranhoangkhuongvn]

There is a long list of error when I tried make -j12:

[ 0%] Built target absl_leak_check_disable
[ 2%] Built target absl_dynamic_annotations
[ 2%] Built target absl_civil_time
[ 3%] Building CXX object abseil-cpp/absl/random/CMakeFiles/absl_random_internal_randen_hwaes_impl.dir/internal/randen_hwaes.cc.o
[ 3%] Built target absl_city
[ 4%] Built target absl_int128
[ 4%] Built target absl_leak_check
[ 5%] Built target absl_strings_internal
[ 6%] Building CXX object abseil-cpp/absl/time/CMakeFiles/absl_time_zone.dir/internal/cctz/src/time_zone_info.cc.o
[ 8%] Built target absl_log_severity
[ 8%] Built target absl_spinlock_wait
[ 8%] Building CXX object CMakeFiles/open_spiel_core.dir/matrix_game.cc.o
[ 8%] Building CXX object CMakeFiles/open_spiel_core.dir/simultaneous_move_game.cc.o
[ 8%] Building CXX object abseil-cpp/absl/time/CMakeFiles/absl_time_zone.dir/internal/cctz/src/time_zone_libc.cc.o
[ 8%] Building CXX object abseil-cpp/absl/random/CMakeFiles/absl_random_internal_randen_slow.dir/internal/randen_slow.cc.o
[ 9%] Built target absl_random_seed_gen_exception
[ 10%] Built target absl_raw_logging_internal
In file included from /Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/abseil-cpp/absl/random/internal/randen_hwaes.cc:26:
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/abseil-cpp/absl/random/internal/platform.h:165:48: error:
'TARGET_OS_IPHONE_SIMULATOR' is not defined, evaluates to 0 [-Werror,-Wundef]
#if defined(APPLE) && (TARGET_OS_IPHONE || TARGET_OS_IPHONE_SIMULATOR)
^
[ 10%] Built target absl_bad_variant_access
[ 11%] Built target absl_scoped_set_env
[ 12%] Built target absl_throw_delegate
[ 12%] Built target absl_bad_optional_access
[ 12%] Built target absl_debugging_internal
[ 14%] Built target absl_base
In file included from /Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/abseil-cpp/absl/random/internal/randen_slow.cc:21:
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/abseil-cpp/absl/random/internal/platform.h:165:48: error:
'TARGET_OS_IPHONE_SIMULATOR' is not defined, evaluates to 0 [-Werror,-Wundef]
#if defined(APPLE) && (TARGET_OS_IPHONE || TARGET_OS_IPHONE_SIMULATOR)
^
1 error generated.
Scanning dependencies of target absl_bad_any_cast_impl
Scanning dependencies of target absl_stacktrace
make[2]: *** [abseil-cpp/absl/random/CMakeFiles/absl_random_internal_randen_hwaes_impl.dir/internal/randen_hwaes.cc.o] Error 1
make[1]: *** [abseil-cpp/absl/random/CMakeFiles/absl_random_internal_randen_hwaes_impl.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
Scanning dependencies of target absl_malloc_internal
Scanning dependencies of target absl_demangle_internal
Scanning dependencies of target absl_strings
1 error generated.
make[2]: *** [abseil-cpp/absl/random/CMakeFiles/absl_random_internal_randen_slow.dir/internal/randen_slow.cc.o] Error 1
make[1]: *** [abseil-cpp/absl/random/CMakeFiles/absl_random_internal_randen_slow.dir/all] Error 2
[ 14%] Building CXX object abseil-cpp/absl/types/CMakeFiles/absl_bad_any_cast_impl.dir/bad_any_cast.cc.o
[ 14%] Building CXX object abseil-cpp/absl/debugging/CMakeFiles/absl_demangle_internal.dir/internal/demangle.cc.o
[ 14%] Building CXX object abseil-cpp/absl/debugging/CMakeFiles/absl_stacktrace.dir/stacktrace.cc.o
[ 14%] Building CXX object abseil-cpp/absl/base/CMakeFiles/absl_malloc_internal.dir/internal/low_level_alloc.cc.o
[ 14%] Building CXX object abseil-cpp/absl/strings/CMakeFiles/absl_strings.dir/ascii.cc.o
[ 14%] Building CXX object abseil-cpp/absl/strings/CMakeFiles/absl_strings.dir/charconv.cc.o
[ 14%] Building CXX object abseil-cpp/absl/strings/CMakeFiles/absl_strings.dir/escaping.cc.o
[ 15%] Building CXX object abseil-cpp/absl/strings/CMakeFiles/absl_strings.dir/internal/charconv_bigint.cc.o
[ 15%] Linking CXX static library libabsl_absl_stacktrace.a
[ 15%] Built target absl_stacktrace
[ 16%] Linking CXX static library libabsl_absl_demangle_internal.a
[ 16%] Building CXX object abseil-cpp/absl/strings/CMakeFiles/absl_strings.dir/internal/charconv_parse.cc.o
[ 16%] Built target absl_demangle_internal
[ 16%] Building CXX object abseil-cpp/absl/strings/CMakeFiles/absl_strings.dir/internal/memutil.cc.o
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/abseil-cpp/absl/time/internal/cctz/src/time_zone_libc.cc:166:22: error:
declaration shadows a local variable [-Werror,-Wshadow]
if (std::tm* tmp = local_time(&lo, &tm)) {
^
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/abseil-cpp/absl/time/internal/cctz/src/time_zone_libc.cc:156:18: note:
previous declaration is here
if (std::tm* tmp = local_time(&mid, &tm)) {
^
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/abseil-cpp/absl/time/internal/cctz/src/time_zone_libc.cc:191:9: error:
result of comparison 'const std::int_fast64_t' (aka 'const long long') < -9223372036854775808 is always false
[-Werror,-Wtautological-type-limit-compare]
if (s < std::numeric_limitsstd::time_t::min()) {
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/abseil-cpp/absl/time/internal/cctz/src/time_zone_libc.cc:195:9: error:
result of comparison 'const std::int_fast64_t' (aka 'const long long') > 9223372036854775807 is always false
[-Werror,-Wtautological-type-limit-compare]
if (s > std::numeric_limitsstd::time_t::max()) {
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 17%] Building CXX object abseil-cpp/absl/strings/CMakeFiles/absl_strings.dir/match.cc.o
3 errors generated.
make[2]: *** [abseil-cpp/absl/time/CMakeFiles/absl_time_zone.dir/internal/cctz/src/time_zone_libc.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
[ 17%] Building CXX object abseil-cpp/absl/strings/CMakeFiles/absl_strings.dir/numbers.cc.o
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/abseil-cpp/absl/time/internal/cctz/src/time_zone_info.cc:737:35: error:
declaration shadows a local variable [-Werror,-Wshadow-uncaptured-local]
name, [](const std::string& name) -> std::unique_ptr {
^
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/abseil-cpp/absl/time/internal/cctz/src/time_zone_info.cc:725:44: note:
previous declaration is here
bool TimeZoneInfo::Load(const std::string& name) {
^
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/abseil-cpp/absl/time/internal/cctz/src/time_zone_info.cc:738:18: error:
declaration shadows a local variable [-Werror,-Wshadow-uncaptured-local]
if (auto zip = FileZoneInfoSource::Open(name)) return zip;
^
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/abseil-cpp/absl/time/internal/cctz/src/time_zone_info.cc:736:8: note:
previous declaration is here
auto zip = cctz_extension::zone_info_source_factory(
^
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/abseil-cpp/absl/time/internal/cctz/src/time_zone_info.cc:739:18: error:
declaration shadows a local variable [-Werror,-Wshadow-uncaptured-local]
if (auto zip = AndroidZoneInfoSource::Open(name)) return zip;
^
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/abseil-cpp/absl/time/internal/cctz/src/time_zone_info.cc:736:8: note:
previous declaration is here
auto zip = cctz_extension::zone_info_source_factory(
^
[ 17%] Linking CXX static library libabsl_absl_bad_any_cast_impl.a
[ 17%] Built target absl_bad_any_cast_impl
[ 17%] Building CXX object abseil-cpp/absl/strings/CMakeFiles/absl_strings.dir/str_cat.cc.o
[ 18%] Building CXX object abseil-cpp/absl/strings/CMakeFiles/absl_strings.dir/str_replace.cc.o
[ 19%] Linking CXX static library libabsl_absl_malloc_internal.a
3 errors generated.
make[2]: *** [abseil-cpp/absl/time/CMakeFiles/absl_time_zone.dir/internal/cctz/src/time_zone_info.cc.o] Error 1
make[1]: *** [abseil-cpp/absl/time/CMakeFiles/absl_time_zone.dir/all] Error 2
[ 19%] Building CXX object abseil-cpp/absl/strings/CMakeFiles/absl_strings.dir/str_split.cc.o
[ 19%] Building CXX object abseil-cpp/absl/strings/CMakeFiles/absl_strings.dir/string_view.cc.o
[ 19%] Building CXX object abseil-cpp/absl/strings/CMakeFiles/absl_strings.dir/substitute.cc.o
[ 19%] Built target absl_malloc_internal
In file included from /Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/matrix_game.cc:15:
In file included from /Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/matrix_game.h:21:
In file included from /Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/normal_form_game.h:18:
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/simultaneous_move_game.h:37:31: error: 'LegalActions'
overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
virtual std::vector LegalActions(int player) const = 0;
^
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/spiel.h:195:31: note: overridden virtual function is
here
virtual std::vector LegalActions(int player) const {
^
In file included from /Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/matrix_game.cc:15:
In file included from /Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/matrix_game.h:21:
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/normal_form_game.h:63:8: error:
'InformationStateAsNormalizedVector' overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
void InformationStateAsNormalizedVector(int player,
^
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/spiel.h:352:16: note: overridden virtual function is
here
virtual void InformationStateAsNormalizedVector(
^
In file included from /Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/simultaneous_move_game.cc:15:
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/simultaneous_move_game.h:37:31: error: 'LegalActions'
overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
virtual std::vector LegalActions(int player) const = 0;
^
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/spiel.h:195:31: note: overridden virtual function is
here
virtual std::vector LegalActions(int player) const {
^
In file included from /Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/matrix_game.cc:15:
In file included from /Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/matrix_game.h:21:
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/normal_form_game.h:77:28: error:
'InformationStateNormalizedVectorShape' overrides a member function but is not marked 'override'
[-Werror,-Winconsistent-missing-override]
virtual std::vector InformationStateNormalizedVectorShape() const {
^
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/spiel.h:557:28: note: overridden virtual function is
here
virtual std::vector InformationStateNormalizedVectorShape() const {
^
In file included from /Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/matrix_game.cc:15:
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/matrix_game.h:121:31: error: 'LegalActions' overrides a
member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
virtual std::vector LegalActions(int player) const {
^
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/simultaneous_move_game.h:37:31: note: overridden virtual
function is here
virtual std::vector LegalActions(int player) const = 0;
^
In file included from /Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/matrix_game.cc:15:
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/matrix_game.h:134:23: error: 'ActionToString' overrides
a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
virtual std::string ActionToString(int player, Action action_id) const {
^
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/spiel.h:237:23: note: overridden virtual function is
here
virtual std::string ActionToString(int player, Action action_id) const = 0;
^
In file included from /Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/matrix_game.cc:15:
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/matrix_game.h:143:16: error: 'IsTerminal' overrides a
member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
virtual bool IsTerminal() const { return !joint_move_.empty(); }
^
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/spiel.h:244:16: note: overridden virtual function is
here
virtual bool IsTerminal() const = 0;
^
In file included from /Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/matrix_game.cc:15:
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/matrix_game.h:145:31: error: 'Returns' overrides a
member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
virtual std::vector Returns() const {
^
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/spiel.h:270:31: note: overridden virtual function is
here
virtual std::vector Returns() const = 0;
^
In file included from /Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/matrix_game.cc:15:
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/matrix_game.h:154:34: error: 'Clone' overrides a member
function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
virtual std::unique_ptr Clone() const {
^
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/spiel.h:408:34: note: overridden virtual function is
here
virtual std::unique_ptr Clone() const = 0;
^
In file included from /Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/matrix_game.cc:15:
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/matrix_game.h:159:16: error: 'DoApplyActions' overrides
a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
virtual void DoApplyActions(const std::vector& moves) {
^
/Users/khuongtran/Documents/fun_learning/AI/open_spiel/open_spiel/../open_spiel/simultaneous_move_game.h:98:8: note: overridden virtual
function is here
void DoApplyActions(const std::vector& actions) override = 0;
^
1 error generated.
make[2]: *** [CMakeFiles/open_spiel_core.dir/simultaneous_move_game.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
9 errors generated.
make[2]: *** [CMakeFiles/open_spiel_core.dir/matrix_game.cc.o] Error 1
make[1]: *** [CMakeFiles/open_spiel_core.dir/all] Error 2
[ 20%] Linking CXX static library libabsl_absl_strings.a
[ 20%] Built target absl_strings
make: *** [all] Error 2

[lanctot]

Ok, thanks.

Seems like you are running into problems building abseil on MacOS, so we will have to look into this.

Unfortunately we were unable to support MacOS officially at release time so we have never built nor tested it on MacOS.

We do intend to support MacOS but it was one thing we were not able to do by this release date.

If you or anyone else manages to build OpenSpiel on MacOS, we would greatly appreciate a pull request for the necessary changes. And we will keep you posted if we make progress on this. Thanks.

[lanctot]

Turns out @mairbek was able to build on MacOS 10.13.3. Take a look at #4 .

There was no report of build problems with abseil, so I wonder if they are not using g++ or whether it requires more setup to get working properly?

[mairbek]

I haven't tweaked anything beyond referenced patch and upgrading brew packages (It is probably not required, I just ran a global brew upgrade since I haven't done C++ coding for a while).

[axissun]

I solved the problem.
On my MacOs, after run ./install.sh，there is no 'abseil-cpp' directory in open_spiel/open_spiel.
So run： git clone -b 'master' --single-branch --depth 1 https://github.com/abseil/abseil-cpp.git open_spiel/abseil-cpp in the base directory.

[lanctot]

Closing this issue. Thank you for the advice on building in MacOS!