Resolved the bug The banner message is causing the search bar to be o… #20794

kunal-511 · 2024-07-30T12:12:28Z

…bscured #20608

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Bug Report: The banner message was obscuring the search bar. #20608
Resolution: The issue has been resolved by adjusting some styles to ensure the below content does not overlap the search bar.
Details: After applying the style changes, the search bar is now fully visible even with the banner message displayed at the top of the page.
For the proof attaching the screenshot

Issue being fixed

Fixes #20608

Please indicate you've done the following:

Well Written Title and Summary of the PR
Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
Accepted the DCO. Commits without the DCO will delay acceptance.
Made sure tests are passing and test coverage is added if needed.
Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

kunal-511 · 2024-07-31T10:41:58Z

Please review this PR @zyyw

AllForNothing · 2024-08-01T01:30:36Z

@ kunal-511 Can you use a dynamic top value to fit the different cases? Using the document.query function to know if there is a banner

has banner: top = 95px
no banner: top = 60px

kunal-511 · 2024-08-01T01:38:51Z

Okay I will look into this

kunal-511 · 2024-08-01T04:20:13Z

@AllForNothing I have added a new commit which now dynamically update the top value depending on wether the banner message is there or not

codecov · 2024-08-02T13:21:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.27%. Comparing base (c8c11b4) to head (90b48ab).
Report is 262 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #20794       +/-   ##
===========================================
+ Coverage   45.36%   66.27%   +20.90%     
===========================================
  Files         244     1046      +802     
  Lines       13333   114173   +100840     
  Branches     2719     2847      +128     
===========================================
+ Hits         6049    75665    +69616     
- Misses       6983    34384    +27401     
- Partials      301     4124     +3823

Flag	Coverage Δ
unittests	`66.27% <ø> (+20.90%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1286 files with indirect coverage changes

AllForNothing · 2024-08-02T13:24:56Z

@kunal-511 Can you refer to this main...AllForNothing:harbor:top-value-search, then update your PR?
the hasValidBannerMessage function is inaccurate as Harbor may have a banner in other cases

kunal-511 · 2024-08-03T04:24:38Z

@AllForNothing I have updated the logic of top value by referring to your feedback. Please check it.

@kunal-511 Can you refer to this main...AllForNothing:harbor:top-value-search, then update your PR? the hasValidBannerMessage function is inaccurate as Harbor may have a banner in other cases

AllForNothing · 2024-08-05T01:11:25Z

src/portal/src/app/shared/components/global-search/search-result.component.ts

+        return headerHeight + bannerHeight;
+    }
+
+    private adjustOverlayTop(): void {


if you use this function to re-render the dom, then you can remove the style binding in [search-result.component.html](https://github.com/goharbor/harbor/pull/20794/files#diff-ec327ae356d30c4098c563bfce30fa1e746dfc33c449e9dcdd0a273c11297c7c)

Please remove this function

src/portal/src/app/shared/components/global-search/search-result.component.ts

kunal-511 · 2024-08-07T04:09:34Z

@AllForNothing I have added a new commit please check

AllForNothing · 2024-08-09T01:20:46Z

@kunal-511 What about just cherrying-pick the changes from main...AllForNothing:harbor:top-value-search.

BTW, you need to sign your commits with 'git commit -s' to pass the DCO check
and run 'npm run lint_fix' to format your code

kunal-511 · 2024-08-17T09:29:32Z

@AllForNothing I have added a new commit. Have a look at it .

AllForNothing · 2024-08-22T01:30:30Z

src/portal/src/app/shared/components/global-search/search-result.component.ts

+    private adjustOverlayTop(): void {
+        const topValue = this.getTopValue();
+    }
+    @HostListener('window:resize', ['$event'])


Please remove this listener

AllForNothing · 2024-08-22T01:31:05Z

src/portal/src/app/shared/components/global-search/search-result.component.ts

+        private searchTrigger: SearchTriggerService,
+        private renderer: Renderer2,
+        private el: ElementRef,
+        private appConfigService: AppConfigService


Please remove these services

goharbor#20721) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.64.0 to 1.64.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.64.0...v1.64.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Shengwen YU <yshengwen@vmware.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Shengwen YU <yshengwen@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

…bscured goharbor#20608 Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

… top value depending on banner message Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

…component Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Signed-off-by: Shengwen Yu <yshengwen@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

1. Mock remote interface for distribution manifest by mockery package feature. 2. Refactor hand-generated mock files to automated management generation. 3. Clean useless mocks. Signed-off-by: chlins <chlins.zhang@gmail.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* add list project arifacts API This API supports listing all artifacts belonging to a specified project. It also allows fetching the latest artifact in each repositry, with the option to filter by either media_type or artifact_type. Signed-off-by: wang yan <wangyan@vmware.com> * resolve the comments Signed-off-by: wang yan <wangyan@vmware.com> --------- Signed-off-by: wang yan <wangyan@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Signed-off-by: xuelichao <xuel@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* Extend regex for c2s support Signed-off-by: Ethan Howell <ethan.c.howell@hotmail.com> * Add more test cases Signed-off-by: Ethan Howell <ethan.c.howell@hotmail.com> * Update region Signed-off-by: Ethan Howell <ethan.c.howell@hotmail.com> * Fix region parsing Signed-off-by: Ethan Howell <ethan.c.howell@hotmail.com> * Add length check Signed-off-by: Ethan Howell <ethan.c.howell@hotmail.com> * Update check Signed-off-by: Ethan Howell <ethan.c.howell@hotmail.com> --------- Signed-off-by: Ethan Howell <ethan.c.howell@hotmail.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Signed-off-by: Shengwen Yu <yshengwen@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Parallel attach LDAP group Add configure LDAP group attach parallel UI Change the /c/login timeout from 60 (nginx default) to 900 seconds in nginx.conf Signed-off-by: stonezdj <stone.zhang@broadcom.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

PR goharbor#18668 (commit bf7c82b) removed notary, but the source code of migrate-patch and some process in the Makefile for it remained, so remove them. Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com> Co-authored-by: Shengwen YU <yshengwen@vmware.com> Co-authored-by: Wang Yan <wangyan@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

fixes goharbor#20828 Signed-off-by: stonezdj <stone.zhang@broadcom.com> Co-authored-by: Shengwen YU <yshengwen@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

…rbor#20659) fix `version` is obsolete warning Signed-off-by: 蝦米 <me@jhdxr.com> Co-authored-by: Wang Yan <wangyan@vmware.com> Co-authored-by: MinerYang <yminer@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Signed-off-by: chlins <chlins.zhang@gmail.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Signed-off-by: Johan Kok <post@johankok.nl> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Signed-off-by: Shengwen Yu <yshengwen@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

1, add creation audit log for robot account 2, add deletion audit log for robot account Signed-off-by: wang yan <wangyan@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

* add creator for robot add the creator for robot creation Signed-off-by: wang yan <wangyan@vmware.com> * resolve comments Signed-off-by: wang yan <wangyan@vmware.com> * fix ut Signed-off-by: wang yan <wangyan@vmware.com> --------- Signed-off-by: wang yan <wangyan@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

kunal-511 requested a review from a team as a code owner July 30, 2024 12:12

github-actions bot assigned chlins, stonezdj and wy65701436 Jul 30, 2024

wy65701436 assigned AllForNothing and unassigned stonezdj Jul 31, 2024

AllForNothing enabled auto-merge (squash) August 2, 2024 12:44

auto-merge was automatically disabled August 3, 2024 04:21
Head branch was pushed to by a user without write access

AllForNothing reviewed Aug 5, 2024

View reviewed changes

src/portal/src/app/shared/components/global-search/search-result.component.ts Outdated Show resolved Hide resolved

wy65701436 added the area/ui label Aug 7, 2024

kunal-511 force-pushed the bug-#20608 branch from 3922db3 to cfbf6c9 Compare August 17, 2024 09:28

kunal-511 requested a review from AllForNothing August 17, 2024 17:01

AllForNothing reviewed Aug 22, 2024

View reviewed changes

dependabot bot and others added 5 commits August 22, 2024 22:28

Resolved the bug The banner message is causing the search bar to be o…

8696cf0

…bscured goharbor#20608 Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Updated the search-result.component.ts file to dynamically update the…

fac9934

… top value depending on banner message Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Check for the other case of baneers also

1bc7e52

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Replace inline style binding with topValue property in search-result.…

a605a5f

…component Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

kunal-511 and others added 17 commits August 22, 2024 22:28

Refactored search overlay component bindings.

2b0f37a

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Removed the listener and clean unused components

e8875d2

Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

add Test Case for SBOM feature (goharbor#20797)

72d7e64

Signed-off-by: Shengwen Yu <yshengwen@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Fixes-20799 can't remove artifact labels (goharbor#20816)

cd698c4

Signed-off-by: xuelichao <xuel@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

feat: implement bandwidth limit for proxy-cache (goharbor#20812)

f21f193

Signed-off-by: Shengwen Yu <yshengwen@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Check create when fire the artifact event (goharbor#20832)

3a1e897

fixes goharbor#20828 Signed-off-by: stonezdj <stone.zhang@broadcom.com> Co-authored-by: Shengwen YU <yshengwen@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

fix: fix the GC job index data race (goharbor#20830)

21f9bcc

Signed-off-by: chlins <chlins.zhang@gmail.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

Fix typo in Swagger API docs (goharbor#20841)

98026a0

Signed-off-by: Johan Kok <post@johankok.nl> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

fix: update e2e test engine images (goharbor#20845)

802ad6a

Signed-off-by: Shengwen Yu <yshengwen@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

enable audit log for robot (goharbor#20843)

0710e8f

1, add creation audit log for robot account 2, add deletion audit log for robot account Signed-off-by: wang yan <wangyan@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>

kunal-511 force-pushed the bug-#20608 branch from b81c230 to 2827912 Compare August 22, 2024 16:58

Merge branch 'main' into bug-goharbor#20608

7112044

kunal-511 closed this Aug 22, 2024

kunal-511 deleted the bug-#20608 branch August 22, 2024 17:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resolved the bug The banner message is causing the search bar to be o… #20794

Resolved the bug The banner message is causing the search bar to be o… #20794

kunal-511 commented Jul 30, 2024 •

edited

Loading

kunal-511 commented Jul 31, 2024

AllForNothing commented Aug 1, 2024

kunal-511 commented Aug 1, 2024

kunal-511 commented Aug 1, 2024

codecov bot commented Aug 2, 2024 •

edited

Loading

AllForNothing commented Aug 2, 2024 •

edited

Loading

kunal-511 commented Aug 3, 2024

AllForNothing Aug 5, 2024

AllForNothing Aug 22, 2024

kunal-511 commented Aug 7, 2024

AllForNothing commented Aug 9, 2024

kunal-511 commented Aug 17, 2024

AllForNothing Aug 22, 2024

AllForNothing Aug 22, 2024

Resolved the bug The banner message is causing the search bar to be o… #20794

Resolved the bug The banner message is causing the search bar to be o… #20794

Conversation

kunal-511 commented Jul 30, 2024 • edited Loading

Comprehensive Summary of your change

Issue being fixed

kunal-511 commented Jul 31, 2024

AllForNothing commented Aug 1, 2024

kunal-511 commented Aug 1, 2024

kunal-511 commented Aug 1, 2024

codecov bot commented Aug 2, 2024 • edited Loading

Codecov Report

AllForNothing commented Aug 2, 2024 • edited Loading

kunal-511 commented Aug 3, 2024

AllForNothing Aug 5, 2024

Choose a reason for hiding this comment

AllForNothing Aug 22, 2024

Choose a reason for hiding this comment

kunal-511 commented Aug 7, 2024

AllForNothing commented Aug 9, 2024

kunal-511 commented Aug 17, 2024

AllForNothing Aug 22, 2024

Choose a reason for hiding this comment

AllForNothing Aug 22, 2024

Choose a reason for hiding this comment

kunal-511 commented Jul 30, 2024 •

edited

Loading

codecov bot commented Aug 2, 2024 •

edited

Loading

AllForNothing commented Aug 2, 2024 •

edited

Loading