-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement bandwidth limit for proxy-cache #20812
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20812 +/- ##
===========================================
+ Coverage 45.36% 66.28% +20.91%
===========================================
Files 244 1046 +802
Lines 13333 114043 +100710
Branches 2719 2845 +126
===========================================
+ Hits 6049 75591 +69542
- Misses 6983 34334 +27351
- Partials 301 4118 +3817
Flags with carried forward coverage won't be shown. Click here to find out more.
|
8178660
to
74e97ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
98fe2f3
to
6257806
Compare
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
bb20fc1
to
67df2c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Shengwen Yu <yshengwen@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #20589
Please indicate you've done the following:
Testing
test case 1: proxy_speed_kb = "-1"
test case 2: proxy_speed_kb = "100"
100 is in kilo bit per second, 100/8 = 12.5 kilo bytes per second
test case 3: proxy_speed_kb = "300"
300 is in kilo bit per second, 300/8 = 37.5 kilo bytes per second
test case 4: proxy_speed_kb = "1024"
1024 is in kilo bit per second, 1024/8 = 128 kilo bytes per second
test case 5: proxy_speed_kb = "102400"
1024 is in kilo bit per second, 1024/8 = 12800 kilo bytes per second