-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check create when fire the artifact event #20832
Conversation
fixes goharbor#20828 Signed-off-by: stonezdj <stone.zhang@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20832 +/- ##
===========================================
+ Coverage 45.36% 66.26% +20.89%
===========================================
Files 244 1045 +801
Lines 13333 114081 +100748
Branches 2719 2845 +126
===========================================
+ Hits 6049 75596 +69547
- Misses 6983 34363 +27380
- Partials 301 4122 +3821
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fixes goharbor#20828 Signed-off-by: stonezdj <stone.zhang@broadcom.com> Co-authored-by: Shengwen YU <yshengwen@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
fixes #20828
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: