add list project arifacts API #20803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API supports listing all artifacts belonging to a specified project. It also allows fetching the latest artifact in each repositry, with the option to filter by either media_type or artifact_type. Signed-off-by: wang yan <wangyan@vmware.com>
wy65701436
added
release-note/enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20803 +/- ##
===========================================
+ Coverage 45.36% 66.28% +20.91%
===========================================
Files 244 1045 +801
Lines 13333 113988 +100655
Branches 2719 2845 +126
===========================================
+ Hits 6049 75557 +69508
- Misses 6983 34311 +27328
- Partials 301 4120 +3819
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chlins
reviewed
Aug 5, 2024
stonezdj
reviewed
Aug 6, 2024
Signed-off-by: wang yan <wangyan@vmware.com>
wy65701436
force-pushed
the
project-artifacts-2
branch
from
482eb9c
to
7c3906c
Compare
stonezdj
reviewed
Aug 6, 2024
| @@ -501,11 +501,12 @@ func (a *artifactAPI) RequireLabelInProject(ctx context.Context, projectID, labe | |||
| return nil | |||
| } | |||
|
|
|||
| func option(withTag, withImmutableStatus, withLabel, withAccessory *bool) *artifact.Option { | |||
| func option(withTag, withImmutableStatus, withLabel, withAccessory *bool, latestInRepository *bool) *artifact.Option { | |||
There was a problem hiding this comment.
It is better to refactor the current option like this
https://github.com/goharbor/harbor/blob/e92674a42ad7461e085db00893f6e16e8cc8d080/src/lib/cache/options.go
stonezdj
approved these changes
Aug 6, 2024
kunal-511
pushed a commit
to kunal-511/harbor_local
that referenced
this pull request
Aug 22, 2024
* add list project arifacts API This API supports listing all artifacts belonging to a specified project. It also allows fetching the latest artifact in each repositry, with the option to filter by either media_type or artifact_type. Signed-off-by: wang yan <wangyan@vmware.com> * resolve the comments Signed-off-by: wang yan <wangyan@vmware.com> --------- Signed-off-by: wang yan <wangyan@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API supports listing all artifacts belonging to a specified project. It also allows fetching the latest artifact in each repositry, with the option to filter by either media_type or artifact_type.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #20756
Please indicate you've done the following: