Detect whether virtual functions are required to override #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
feature
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-904 |
|
This looks great 👏 |
|
In a second step, I was planning to export the 4.4 data about which virtual functions are required, and use it for the hardcoded list in API levels 4.1-4.3. This would of course not work if "required-ness" changes in between, but I'd still expect it to be more accurate than the current list. |
|
@Bromeon the last time I updated the hard-coded list I basically did that. I used the WIP branch on the engine, dumped the API and more or less pasted the data as rust code. So I think we should be totally fine with using a static JSON. |
From Godot 4.4 onward, we can use the GDExtension-provided information, which states whether virtual functions have a default implementation or are required to be overridden.
Bromeon
force-pushed
the
feature/detect-required-virtuals
branch
from
7b03ec3
to
b1db236
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Godot 4.4 onward, we can use the GDExtension-provided information, which states whether virtual functions have a default implementation or are required to be overridden.
Depends on upstream godotengine/godot#93311.