Validate that virtual extension classes require #[class(tool)]
#850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
quality-of-life
Bromeon
force-pushed
the
qol/require-tool-for-virtual-extensions
branch
from
011d157
to
62bbf1d
Compare
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-850 |
|
Looks good. Tried it with |
|
@Bromeon I see I'm just a bit too late. It just came to my mind that we perhaps also want to include |
|
Hm good idea -- would you mind opening a PR for it? Since you already have some classes in mind 🤔 |
|
Yeah I can do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation for an issue brought up in #826 (comment).
@TitanNano you might want to have a look?