Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds --filtering option to check.sh #308

Merged
merged 2 commits into from
Jul 9, 2023

Conversation

astrale-sharp
Copy link
Contributor

note that check.sh itest --filtering clippy wont parse clippy as a filter but as an arg

it shouldn't pose problems except maybe for fmt, I don't feel extremely confident improving the parsing in the sh language but if it's required i could rewrite it as a little rust script and pico-arg or something else.

this filters all tests.

@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-308

@Bromeon Bromeon added feature Adds functionality to the library c: tooling CI, automation, tools labels Jun 13, 2023
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

I'd name it --filter, not --filtering. Could also come with a shortcut -f.

Now you run the filter logic twice, once in GDScript and once in Rust. Would it not be possible to have it in Rust only, and filter the VariantArray after passing it to Rust?

bors try

check.sh Outdated Show resolved Hide resolved
check.sh Outdated Show resolved Hide resolved
check.sh Outdated Show resolved Hide resolved
itest/godot/TestRunner.gd Outdated Show resolved Hide resolved
itest/godot/TestRunner.gd Outdated Show resolved Hide resolved
itest/godot/TestRunner.gd Outdated Show resolved Hide resolved
itest/rust/src/lib.rs Outdated Show resolved Hide resolved
itest/rust/src/runner.rs Outdated Show resolved Hide resolved
bors bot added a commit that referenced this pull request Jun 13, 2023
@bors
Copy link
Contributor

bors bot commented Jun 13, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@astrale-sharp astrale-sharp force-pushed the test-filter branch 6 times, most recently from 2924826 to 46f93e8 Compare June 15, 2023 08:11
Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! A few things left 🙂

check.sh Outdated Show resolved Hide resolved
itest/rust/src/runner.rs Outdated Show resolved Hide resolved
itest/godot/TestRunner.gd Outdated Show resolved Hide resolved
itest/rust/src/runner.rs Outdated Show resolved Hide resolved
@astrale-sharp astrale-sharp force-pushed the test-filter branch 3 times, most recently from aaa16d8 to 9d6ee8c Compare July 8, 2023 16:47
@astrale-sharp
Copy link
Contributor Author

This should be good to go!

@Bromeon
Copy link
Member

Bromeon commented Jul 9, 2023

Added a few things:

  • Error message when -f/--filter is provided without having itest as a command
  • Fix --filtering still being used

Thanks!
bors r+

@bors
Copy link
Contributor

bors bot commented Jul 9, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

  • full-ci

@bors bors bot merged commit 01bc0c8 into godot-rust:master Jul 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: tooling CI, automation, tools feature Adds functionality to the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants