-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds --filtering option to check.sh #308
Conversation
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-308 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
I'd name it --filter
, not --filtering
. Could also come with a shortcut -f
.
Now you run the filter logic twice, once in GDScript and once in Rust. Would it not be possible to have it in Rust only, and filter the VariantArray
after passing it to Rust?
bors try
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
2924826
to
46f93e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! A few things left 🙂
aaa16d8
to
9d6ee8c
Compare
9d6ee8c
to
de20581
Compare
This should be good to go! |
Added a few things:
Thanks! |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
note that
check.sh itest --filtering clippy
wont parse clippy as a filter but as an argit shouldn't pose problems except maybe for fmt, I don't feel extremely confident improving the parsing in the sh language but if it's required i could rewrite it as a little rust script and pico-arg or something else.
this filters all tests.