Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] terminals resizing issues on reload #3553

Closed
akosyakov opened this issue Mar 23, 2021 · 3 comments · Fixed by #3937 or #4046
Closed

[vscode] terminals resizing issues on reload #3553

akosyakov opened this issue Mar 23, 2021 · 3 comments · Fixed by #3937 or #4046
Assignees
Labels

Comments

@akosyakov
Copy link
Member

akosyakov commented Mar 23, 2021

Bug description

On page reload the content is not nicely resized.

Steps to reproduce

  • Start a workspace with VS Code
  • Reload the page and output should be nicely formatted.
  • But it is rendered narrowly instead.

There are also strange messages in terminals on start sometimes:

your 131072x1 screen size is bogus. expect trouble

Expected behavior

No response

Example repository

No response

@akosyakov akosyakov added type: bug Something isn't working editor: code (browser) labels Mar 23, 2021
@akosyakov akosyakov added this to the March 2021 milestone Mar 23, 2021
@akosyakov akosyakov self-assigned this Mar 23, 2021
@akosyakov akosyakov added the priority: 💪 stretch goal This issue is a stretch goal within an iteration. label Mar 25, 2021
@akosyakov akosyakov modified the milestones: March 2021, [backlog] April 2021 Mar 27, 2021
@akosyakov akosyakov removed the priority: 💪 stretch goal This issue is a stretch goal within an iteration. label Mar 28, 2021
@akosyakov akosyakov modified the milestones: April 2021, May 2021 (backlog) Apr 13, 2021
@akosyakov
Copy link
Member Author

I was able to reproduce by removing focus from the window, i.e. opening another tab while reloading. The theory is that we push data while terminal did not compute proper sizes yet, so it is rendering everything with default, i.e. 1 cols, 1 rows.

@akosyakov akosyakov modified the milestones: May 2021 (backlog), April 2021 Apr 14, 2021
@akosyakov
Copy link
Member Author

I used bogus initial resize sizes, i.e. (1, 1). It should be (0, 0) then they are overidden by initial resize. I will fix in the context of #3694

@jankeromnes
Copy link
Contributor

I was just able to reproduce this issue, twice in a row, by opening:

https://akosyakov-unable-to-open-files-3874.staging.gitpod-dev.com/#https://github.com/whatwg/html

Screenshot 2021-04-22 at 17 14 56

in Firefox Nightly (88) on Mac OS.

This is the preview environment of #4040 that was just merged into Gitpod Core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants