Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] use 0 cols and rows as default pty size #4046

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Apr 23, 2021

What it does

  • fix [vscode] terminals resizing issues on reload #3553: the pty can produce data before the initial size is provided, so instead of setting (1, 1) as initial size, we set (0, 0) meaning that pty should use internal default which later get overridden by the initial size

Change in Gitpod Code: gitpod-io/openvscode-server@cee6bf3

How to test

  • Start a workspace.
  • Emulate slow connection on OS level, start a new terminal.
  • You should not see anything like your 131072x1 screen size is bogus. expect trouble
  • Some content thought can be resized bogusly since it was produced before the initial resize but after that the size should be correct. You can verify current size with stty -a

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good & reliably fixes the problem.

Thanks for another cool fix!

@akosyakov akosyakov merged commit 079af3f into main Apr 23, 2021
@akosyakov akosyakov deleted the ak/code_default_term_size branch April 23, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vscode] terminals resizing issues on reload
2 participants