Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supervisor/code] grpc tracing and terminal fixes #3504

Merged
merged 4 commits into from
Mar 23, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Mar 19, 2021

What it does

Changes in VS Code: gitpod-io/openvscode-server#8

Additional env variables which were useful to investigate grpc over http2:

# enable @grpc/grpc-js tracing
export GRPC_NODE_VERBOSITY=DEBUG
export GRPC_NODE_TRACE=all

# enable node http2 tracing
export NODE_DEBUG=http2

How to test

@akosyakov akosyakov force-pushed the ak/supervisor_debug_mode branch 4 times, most recently from 15d5c22 to 51baf78 Compare March 19, 2021 13:19
@akosyakov akosyakov marked this pull request as draft March 19, 2021 14:16
@akosyakov akosyakov force-pushed the ak/supervisor_debug_mode branch 4 times, most recently from 3751900 to 79523cc Compare March 23, 2021 09:39
@akosyakov akosyakov changed the title [supervisor] allow to enable pprof and grpc tracing [supervisor/code] grpc tracing and terminal fixes Mar 23, 2021
@akosyakov akosyakov marked this pull request as ready for review March 23, 2021 10:26
@geropl
Copy link
Member

geropl commented Mar 23, 2021

Reviewing...

@svenefftinge
Copy link
Member

I started a workspace and created a bunch of terminals. They all worked and survived multiple reloads without any issues.
One thing I saw is that the width of the logs outputted before the IDE was visible were rendered narrowly (3 cols or so).

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works really nice.

@geropl
Copy link
Member

geropl commented Mar 23, 2021

Not sure if it's related and what's the trigger: Sometimes all terminals in one "row" get cramped to the right:
image

Maybe on vertical re-sizing...

@akosyakov
Copy link
Member Author

I'm merging and will tackle terminal resize issues separately.

@akosyakov
Copy link
Member Author

A follow up issue about terminal resize: #3553

@akosyakov akosyakov merged commit fbb86ca into main Mar 23, 2021
@akosyakov akosyakov deleted the ak/supervisor_debug_mode branch March 23, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminals aren't reconnected on Code reload [code] terminals stop working
3 participants