-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[supervisor/code] grpc tracing and terminal fixes #3504
Conversation
15d5c22
to
51baf78
Compare
3751900
to
79523cc
Compare
79523cc
to
aebbfd5
Compare
Reviewing... |
I started a workspace and created a bunch of terminals. They all worked and survived multiple reloads without any issues. |
aebbfd5
to
0f4e010
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works really nice.
0f4e010
to
0e5ccc9
Compare
0e5ccc9
to
da60853
Compare
I'm merging and will tackle terminal resize issues separately. |
A follow up issue about terminal resize: #3553 |
What it does
Changes in VS Code: gitpod-io/openvscode-server#8
Additional env variables which were useful to investigate grpc over http2:
How to test
_supervisor/debug/pprof
endpoint on a workspace origin