Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] add missing web deps #4040

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Apr 22, 2021

What it does

Change in Gitpod Code: gitpod-io/openvscode-server@9701055

How to test

  • Start a workspace.
  • Check jschardet is there, it should be on this path: node_modules/jschardet/dist/jschardet.min.js

@jankeromnes jankeromnes self-requested a review April 22, 2021 14:12
@akosyakov akosyakov force-pushed the akosyakov/unable-to-open-files-3874 branch from 6258f8f to 59e738a Compare April 22, 2021 14:13
exec /ide/node/bin/gitpod-node ./out/gitpod.js $*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a clean up

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer wish to run gitpod-node with a debugging port open?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is confusing, a user sees some port exposed when he does not start anything. I think it is better not to do it.

@jankeromnes
Copy link
Contributor

jankeromnes commented Apr 22, 2021

Taking a look. 👀

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and works as advertised. Thanks!

Screenshot 2021-04-22 at 16 52 21

@akosyakov akosyakov merged commit 8b78e0d into main Apr 22, 2021
@akosyakov akosyakov deleted the akosyakov/unable-to-open-files-3874 branch April 22, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to open files i get a string that says [object event]
2 participants