Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.15.0 #686

Merged
merged 4 commits into from
Feb 1, 2023
Merged

release 0.15.0 #686

merged 4 commits into from
Feb 1, 2023

Conversation

forrestguice
Copy link
Owner

@forrestguice forrestguice commented Jan 30, 2023

96 (0.14.12) -> 97 (0.15.0)
@forrestguice forrestguice added this to the v0.15.0 milestone Jan 30, 2023
@forrestguice
Copy link
Owner Author

Adding code means adding bugs.
I'm releasing v0.15.0 as it is.

I think this could use more testing, but I'm running low on energy.. Time to recharge.
If I've missed something obvious (hope not), it can always be fixed in the next patch.

@forrestguice forrestguice merged commit d0e52be into master Feb 1, 2023
@jackthebean
Copy link

Great load of improvements. Thanks for all the work.

@forrestguice forrestguice deleted the release-0.15.0 branch February 1, 2023 22:09
@jackthebean
Copy link

jackthebean commented Feb 15, 2023

Thanks for all the improvements.

However looking at below:

yJ0gRWXFqd0er8cu

I cannot work out what the marked bit shows and cannot see anywhere that describes it.

Also in the help page the descriptions are a bit unclear. Clearer are those at

www.weather.gov

Twilight Types

🔗 https://www.weather.gov/lmk/twilight-types

which make it clearer that civil twilight is, for example, a period between 6 and 12 degrees below horizon rather than just at 6 degrees.

It would be good to have option to put back those timings eg nautical and astronomical twilights which have disappeared from the standard view.

Oddity: When I tap on day length icon near bottom of default page it shows different days. Today is 13th Feb and if I tap on it it shows data for 13th, if I change main screen to 12th it still shows 13th, change main screen to 11th and tapping on day length bar bring up data for 11th. Same if going into the future. 14th shows 13th and 15th shows 15th.

See below

0y4PCsob1CHdFBUO

k3oYqJinBpNjhQ4J

QDagfwfDYmIMQ1ox

@forrestguice
Copy link
Owner Author

forrestguice commented Feb 15, 2023

Hi. I was just about to tag the next patch, and saw this (normally responses aren't so quick ;)

I cannot work out what the marked bit shows and cannot see anywhere that describes it.

0.93 m is the object height, 2.79 m is the shadow length, and 2.07 m is shadow length at noon. Click : -> Object Shadow to change the object height (or click that area). There should also be a line mentioning it from : -> Help.

It would be good to have option to put back those timings eg nautical and astronomical twilights which have disappeared from the standard view.

These were removed from defaults after receiving some (blistering) criticism about the table being overcrowded. You can restore them from Settings -> User Interface -> Nautical Twilight, etc.

which make it clearer that civil twilight is, for example, a period between 6 and 12 degrees below horizon rather than just at 6 degrees.

This is actually nautical twilight (6 to 12 degrees). In the morning, civil twilight begins at 6 degrees, and ends at sunrise (0), and vice versa in the evening (beings at sunset (0), ends at 6 degrees). The "note area" ("2h 11m until noon" (next to clock)) makes some attempt to clarify, by using phrases "until civil twilight" in the morning, and "until end civil twilight" in the evening. Agreed it is still confusing if you aren't already familiar with the domain.

Oddity: When I tap on day length icon near bottom of default page it shows different days. Today is 13th Feb and if I tap on it it shows data for 13th, if I change main screen to 12th it still shows 13th, change main screen to 11th and tapping on day length bar bring up data for 11th. Same if going into the future. 14th shows 13th and 15th shows 15th.

Good catch. This seems like something left over from the previous implementation - the "yestderday/today/tomorrow" are a special case (for a reason I can no longer remember) - they are passing the same date (today) when opening the dialog.

@forrestguice
Copy link
Owner Author

forrestguice commented Feb 15, 2023

That "oddity" is something to be fixed with v0.15.2.
We can expand the help too. It is intentionally brief, but another sentence wouldn't hurt. It needs to communicate that the morning times (rising times) indicate the start of twilight, while evening times indicate its end.

@forrestguice
Copy link
Owner Author

Reading this once more (because I rush sometimes)..

In that first screenshot, it indicates an infinite shadow, maybe a funny way of saying the sun is below the horizon.
That part of the dialog has been a bit of an undocumented feature for awhile. The help dialog (and the line explaining the icon) are recent additions.

@jackthebean
Copy link

As you say - a very quick response!

Sorry I may be being dim but what is the object that has a height of 0.93m? Is this just a ' an object 0.93m tall would have a shadow.....' ? Why 0.93m? Thought it might be exact imperial unit but isn't. Nothing about it on the help page.

Will try to write a version update for the help if that would be useful. And will get civil twilight right!
Thanks for the rest.

@forrestguice
Copy link
Owner Author

forrestguice commented Feb 16, 2023

Is this just a ' an object 0.93m tall would have a shadow....

Yes, this - just some object. I think the most useful value is probably your own height. Units should be metric by default, but this can be changed from Settings -> General.

Why 0.93m?

I'm not sure, but I'm guessing at some point while exploring the UI the height slider was dragged. The default value should be 6ft (~1.83 m).

@jackthebean
Copy link

Pretty sure that I never changed the height slider but have now. Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment