Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Custom Offset +- to Sunset #537

Closed
codeandfix opened this issue Jan 17, 2022 · 7 comments · Fixed by #686 or #710
Closed

Feature Request: Custom Offset +- to Sunset #537

codeandfix opened this issue Jan 17, 2022 · 7 comments · Fixed by #686 or #710
Milestone

Comments

@codeandfix
Copy link

Actually i can see the Sunset Time according to Place+Civil/Nautical/Astronomical.
But i prefer to have an Offset like +1.5h after sunset and -1.5h before sunset based on civil time.

@forrestguice
Copy link
Owner

Hi. If I'm understanding correctly, the feature you're describing is available in SuntimesAlarms.

Try creating an alarm for either sunset or evening civil twilight, then, from the edit alarm screen, click the at button to set a before/after offset.

@forrestguice
Copy link
Owner

A few others have also inquired about this.. I think this feature might be advertised better (poor discoverability).
For example, in previous versions of the app, the options were also available from an overflow menu.

@codeandfix
Copy link
Author

maybe, but i dont need an alert, i just want to see the time as a value in the table like civil, nautical, etc?

@forrestguice
Copy link
Owner

thanks for clarifying.
yeah, it isn't currently possible.

I think a general feature might be the ability to add custom fields, which can then be toggled in the table, shown in a widget, or assigned to an alarm/notification, etc. These fields could be some arbitrary elevation (custom twilight event), or degree offset some event (#522), or an offset in minutes (as suggested here).

forrestguice added a commit that referenced this issue Feb 5, 2022
adds an overflow submenu to AlarmEditActivity; provides an alternate way access/discover alarm features. #416 #522 #537
@codeandfix
Copy link
Author

yes, just an offset to an existing time and a custom name in the list would be enough.

means: myTime = civil +1.5h
and this value should be shown next to the other items like civil, natical, etc.

@codeandfix
Copy link
Author

completed, but how can i set it up??

@forrestguice
Copy link
Owner

forrestguice commented Apr 8, 2023

Apologies. I have some bad news. It seems I actually marked this complete by mistake in the process of releasing the "custom events" feature. I even wrote out a short explanation for the UI before realizing my mistake. :\

The good news is "custom events" makes a ton of progress toward this. It can be included in an upcoming patch (most likely v0.15.4).

@forrestguice forrestguice reopened this Apr 8, 2023
@forrestguice forrestguice added this to the v0.15.4 milestone Apr 17, 2023
forrestguice added a commit that referenced this issue May 28, 2023
custom ElevationEvent to support an offset in minutes (#537)
forrestguice added a commit that referenced this issue May 28, 2023
adds `offset` button to custom event dialog (#537)
forrestguice added a commit that referenced this issue May 28, 2023
apply offsets (#537)
This was referenced Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants