Move from antlr4JS to antlr4TS #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #96 +/- ##
===========================================
+ Coverage 94.21% 94.32% +0.10%
===========================================
Files 42 42
Lines 1106 1127 +21
Branches 234 223 -11
===========================================
+ Hits 1042 1063 +21
Misses 62 62
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dobladez
requested review from
amphro,
code0100fun,
dehru,
jgellin-sf,
jonnyhork,
mysticflute,
praksb and
tmock12
as code owners
jgellin-sf
previously approved these changes
Nov 19, 2020
Comment on lines
+223
to
+227
| /** | ||
| // If we want to use a proper Visitor: | ||
| class QueryVisitor | ||
| extends AbstractParseTreeVisitor<void> | ||
| implements SoqlParserVisitor<void> { | ||
| protected defaultResult(): void {} | ||
| visitSoqlFromExpr(ctx: Parser.SoqlFromExprContext): void {} | ||
| } | ||
| */ |
Contributor
There was a problem hiding this comment.
Now that we have access to a visitor parent class, I think this is something we want to do. Maybe in a separate PR.
Contributor
Author
|
@jgellin-sf I should've kept this PR as DRAFT until you merged your |
dobladez
force-pushed
the
antlr4ts_W-8432027_b
branch
from
2616d6a to
7e0437c
Compare
dobladez
commented
Nov 19, 2020
Comment on lines
+1
to
+5
| { | ||
| "printWidth": 80, | ||
| "tabWidth": 2, | ||
| "singleQuote": true | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I've had a hard time rebasing this branch given the many lines modified by VSCode just due to formatting :-(.
That's why I'm adding a common .prettierrc, like we have on our SOQL extension repo.
jgellin-sf
previously approved these changes
Nov 20, 2020
The main reason we are doing this migration is to be able to leverage lib antlr-c3 for code-completion. Also: add a top-level prettierrc config file.
dobladez
force-pushed
the
antlr4ts_W-8432027_b
branch
from
7e0437c to
3550a9d
Compare
jgellin-sf
approved these changes
Dec 1, 2020
dehru
added a commit
that referenced
this pull request
Jan 15, 2021
* model WHERE clause (#68) * Remote SOQL Errors - Language Server Part (#93) * remove code builder (#92) * Move from antlr4JS to antlr4TS (#96) * SOQL code completion for SELECT fields (#99) * publish language server 0.2.9 (#102) * Fix LSP dependency (#104) * Disabled 'Running...' button while query running (#106) * Add basic code-completion for ORDER BY and other improvements (#107) * Dehru and JG telemetry - Send GDPR clean data to telemetry when errors/unsupported syntax present (#110) * Disable WHERE in model (#113) * Bump versions for publishing (#114) * Code-completion for WHERE clause expressions (#112) Co-authored-by: Jonathan Gellin <jgellin@salesforce.com> Co-authored-by: jgellin-sf <55159130+jgellin-sf@users.noreply.github.com> Co-authored-by: Chase McCarthy <charles.mccarthy@heroku.com> Co-authored-by: Jonny Hork <jhork@salesforce.com> Co-authored-by: Fernando Dobladez <fernandodobladez@salesforce.com> Co-authored-by: Jonathan Gellin <jgellin@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move from antlr4JS to antlr4TS
Note: this PR depends on the soql-parser from this pending PR: https://git.soma.salesforce.com/enterprise-api/soql-parser/pull/50
What issues does this PR fix or reference?
W-8432027