Fix LSP dependency #104
Merged
Fix LSP dependency #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgellin-sf
requested review from
amphro,
code0100fun,
dehru,
jonnyhork,
mysticflute,
praksb and
tmock12
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #104 +/- ##
========================================
Coverage 94.62% 94.62%
========================================
Files 43 43
Lines 1283 1283
Branches 282 283 +1
========================================
Hits 1214 1214
Misses 67 67
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
jgellin-sf
commented
Dec 15, 2020
Comment on lines
+25
to
+27
| "resolutions": { | ||
| "**/vscode-languageserver-protocol": "3.15.3" | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Yarn will not automatically hoist the pinned version of a dependency of a dependency, even when it is in the accepted range for resolution. This field overrides yarn's default behavior.
Contributor
|
LGTM |
dehru
approved these changes
Dec 15, 2020
Contributor
|
Do we need to publish this? |
Contributor
Author
|
Probably, but there's no version bump in this PR. My intention was to unblock development, and this is a start. |
dehru
added a commit
that referenced
this pull request
Jan 15, 2021
* model WHERE clause (#68) * Remote SOQL Errors - Language Server Part (#93) * remove code builder (#92) * Move from antlr4JS to antlr4TS (#96) * SOQL code completion for SELECT fields (#99) * publish language server 0.2.9 (#102) * Fix LSP dependency (#104) * Disabled 'Running...' button while query running (#106) * Add basic code-completion for ORDER BY and other improvements (#107) * Dehru and JG telemetry - Send GDPR clean data to telemetry when errors/unsupported syntax present (#110) * Disable WHERE in model (#113) * Bump versions for publishing (#114) * Code-completion for WHERE clause expressions (#112) Co-authored-by: Jonathan Gellin <jgellin@salesforce.com> Co-authored-by: jgellin-sf <55159130+jgellin-sf@users.noreply.github.com> Co-authored-by: Chase McCarthy <charles.mccarthy@heroku.com> Co-authored-by: Jonny Hork <jhork@salesforce.com> Co-authored-by: Fernando Dobladez <fernandodobladez@salesforce.com> Co-authored-by: Jonathan Gellin <jgellin@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
VSCode has made some dodgy version changes with their latest updates that have broken our build. This PR pins us to a specific version of a dependency to work around the problem.
What issues does this PR fix or reference?
@W-8582993@