Dehru and JG telemetry - Send GDPR clean data to telemetry when errors/unsupported syntax present #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehru
requested review from
amphro,
code0100fun,
jgellin-sf,
jonnyhork,
mysticflute,
praksb and
tmock12
as code owners
dehru
commented
Dec 23, 2020
| telemetry.errors = query.errors.map( | ||
| (err) => `${err.type}:${err.grammarRule}` | ||
| ); | ||
| telemetry.unsupported = query.unsupported.map((unsup) => unsup.reason); |
Contributor
Author
There was a problem hiding this comment.
this uses jon's new reason attribute of unsupported array.
dehru
commented
Dec 23, 2020
| * This method collects all the unmodelled syntax it finds into a collection and returns it. | ||
| * @param model | ||
| * @param collector | ||
| */ |
Contributor
Author
There was a problem hiding this comment.
@jgellin-sf - I used your self-referential function as a model for this. However, i'm keeping both since yours has a fast "return" while this one continues to gather all the nodes.
Contributor
|
QA complete. |
dehru
added a commit
that referenced
this pull request
Jan 15, 2021
* model WHERE clause (#68) * Remote SOQL Errors - Language Server Part (#93) * remove code builder (#92) * Move from antlr4JS to antlr4TS (#96) * SOQL code completion for SELECT fields (#99) * publish language server 0.2.9 (#102) * Fix LSP dependency (#104) * Disabled 'Running...' button while query running (#106) * Add basic code-completion for ORDER BY and other improvements (#107) * Dehru and JG telemetry - Send GDPR clean data to telemetry when errors/unsupported syntax present (#110) * Disable WHERE in model (#113) * Bump versions for publishing (#114) * Code-completion for WHERE clause expressions (#112) Co-authored-by: Jonathan Gellin <jgellin@salesforce.com> Co-authored-by: jgellin-sf <55159130+jgellin-sf@users.noreply.github.com> Co-authored-by: Chase McCarthy <charles.mccarthy@heroku.com> Co-authored-by: Jonny Hork <jhork@salesforce.com> Co-authored-by: Fernando Dobladez <fernandodobladez@salesforce.com> Co-authored-by: Jonathan Gellin <jgellin@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is a combination of JG's PR 103 and my PR 100. Those PRs have been closed and combined into this PR.
The effort to remove any GDPR protected data from telemetry, and then posting telemetry data about errors and unsupported syntax so we can better understand where we aren't meeting our customer's needs.
What issues does this PR fix or reference?
@W-8547957@, @W-8086238@