Code-completion for WHERE clause expressions #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobladez
requested review from
amphro,
code0100fun,
dehru,
jgellin-sf,
jonnyhork,
mysticflute,
praksb and
tmock12
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #112 +/- ##
===========================================
+ Coverage 86.94% 87.61% +0.67%
===========================================
Files 46 46
Lines 1409 1470 +61
Branches 310 334 +24
===========================================
+ Hits 1225 1288 +63
+ Misses 182 180 -2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
Author
soqlCompletionWHERE_3.movsoqlCompletionWHERE_dateliterals.mov |
dobladez
changed the title
This was referenced Jan 4, 2021
dobladez
force-pushed
the
feature/code-completion-WHERE
branch
from
2a05347 to
b3c5a0d
Compare
* Complete operators based on type of field * Complete literal values based on field
Also: Offer NULL as a completion value only if operator in context allows nulls.
dobladez
force-pushed
the
feature/code-completion-WHERE
branch
from
b3c5a0d to
d84ea24
Compare
Contributor
|
QA complete. |
jgellin-sf
approved these changes
Jan 15, 2021
dehru
added a commit
that referenced
this pull request
Jan 15, 2021
* model WHERE clause (#68) * Remote SOQL Errors - Language Server Part (#93) * remove code builder (#92) * Move from antlr4JS to antlr4TS (#96) * SOQL code completion for SELECT fields (#99) * publish language server 0.2.9 (#102) * Fix LSP dependency (#104) * Disabled 'Running...' button while query running (#106) * Add basic code-completion for ORDER BY and other improvements (#107) * Dehru and JG telemetry - Send GDPR clean data to telemetry when errors/unsupported syntax present (#110) * Disable WHERE in model (#113) * Bump versions for publishing (#114) * Code-completion for WHERE clause expressions (#112) Co-authored-by: Jonathan Gellin <jgellin@salesforce.com> Co-authored-by: jgellin-sf <55159130+jgellin-sf@users.noreply.github.com> Co-authored-by: Chase McCarthy <charles.mccarthy@heroku.com> Co-authored-by: Jonny Hork <jhork@salesforce.com> Co-authored-by: Fernando Dobladez <fernandodobladez@salesforce.com> Co-authored-by: Jonathan Gellin <jgellin@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add smart code-completion for WHERE clause expressions.
Also: Refactoring of "placeholder" completion items: send JSON data instead of parseable values inside item label string.
NOTE 1: Depends on VS Code extension branch: feature/soql-code-completion-WHERE
NOTE 2: This PR is on top of #107 (branch feature/code-completion-ORDER_BY)What issues does this PR fix or reference?
W-8597428