Propagate custom_info Dict through agent Resource #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddl-ebrown
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
ddl-ebrown
commented
May 16, 2024
ddl-ebrown
force-pushed
the
add-custom_info-to-Resource
branch
7 times, most recently
from
51c3825
to
67865b7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2426 +/- ##
==========================================
+ Coverage 72.10% 77.62% +5.51%
==========================================
Files 181 238 +57
Lines 18395 20841 +2446
Branches 3601 3600 -1
==========================================
+ Hits 13264 16178 +2914
+ Misses 4506 4062 -444
+ Partials 625 601 -24 ☔ View full report in Codecov by Sentry. |
ddl-ebrown
force-pushed
the
add-custom_info-to-Resource
branch
3 times, most recently
from
1218914
to
b337afe
Compare
3 tasks
ddl-ebrown
force-pushed
the
add-custom_info-to-Resource
branch
3 times, most recently
from
f237b5c
to
2fd654a
Compare
2 tasks
|
Tracking issue: flyteorg/flyte#5603 |
3 tasks
|
@ddl-rliu Could you rebase the PR to fix the CI error? |
ddl-rliu
force-pushed
the
add-custom_info-to-Resource
branch
from
2fd654a
to
a9c9c46
Compare
ddl-rliu
requested review from
thomasjpfan and
Future-Outlier
as code owners
|
something wrong in the github |
ddl-rliu
force-pushed
the
add-custom_info-to-Resource
branch
from
f29140d
to
d56aea3
Compare
|
Fixed! |
pingsutw
previously approved these changes
Sep 9, 2024
|
@ddl-rliu overall lgtm, some tests are failing though. |
- The agent defines a Resource return type with values: * outputs * message * log_links * phase These are all a part of the underlying protobuf contract defined in flyteidl. However, the message field custom_info from the protobuf is not here google.protobuf.Struct custom_info https://github.com/flyteorg/flyte/blob/519080b6e4e53fc0e216b5715ad9b5b5270f35c0/flyteidl/protos/flyteidl/admin/agent.proto#L140 This field was added in flyteorg/flyte#4874 but never made it into the corresponding flytekit PR flyteorg#2146 - It's useful for agents to return additional metadata about the job, and it looks like custom_info is the intended location - Make a minor refactor to how the agent responds to requests that return Resource by implementing to_flyte_idl / from_flyte_idl directly Signed-off-by: ddl-ebrown <ethan.brown@dominodatalab.com> Signed-off-by: ddl-rliu <richard.liu@dominodatalab.com>
ddl-rliu
force-pushed
the
add-custom_info-to-Resource
branch
from
46b56ad
to
1a6348c
Compare
|
test errors should be fixed now 👍 |
eapolinario
approved these changes
Sep 26, 2024
otarabai
pushed a commit
to otarabai/flytekit
that referenced
this pull request
Oct 15, 2024
* Propagate custom_info Dict through agent Resource - The agent defines a Resource return type with values: * outputs * message * log_links * phase These are all a part of the underlying protobuf contract defined in flyteidl. However, the message field custom_info from the protobuf is not here google.protobuf.Struct custom_info https://github.com/flyteorg/flyte/blob/519080b6e4e53fc0e216b5715ad9b5b5270f35c0/flyteidl/protos/flyteidl/admin/agent.proto#L140 This field was added in flyteorg/flyte#4874 but never made it into the corresponding flytekit PR flyteorg#2146 - It's useful for agents to return additional metadata about the job, and it looks like custom_info is the intended location - Make a minor refactor to how the agent responds to requests that return Resource by implementing to_flyte_idl / from_flyte_idl directly Signed-off-by: ddl-ebrown <ethan.brown@dominodatalab.com> Signed-off-by: ddl-rliu <richard.liu@dominodatalab.com> * Fix test Signed-off-by: ddl-rliu <richard.liu@dominodatalab.com> --------- Signed-off-by: ddl-ebrown <ethan.brown@dominodatalab.com> Signed-off-by: ddl-rliu <richard.liu@dominodatalab.com> Co-authored-by: ddl-rliu <richard.liu@dominodatalab.com>
kumare3
pushed a commit
that referenced
this pull request
Nov 8, 2024
* Propagate custom_info Dict through agent Resource - The agent defines a Resource return type with values: * outputs * message * log_links * phase These are all a part of the underlying protobuf contract defined in flyteidl. However, the message field custom_info from the protobuf is not here google.protobuf.Struct custom_info https://github.com/flyteorg/flyte/blob/519080b6e4e53fc0e216b5715ad9b5b5270f35c0/flyteidl/protos/flyteidl/admin/agent.proto#L140 This field was added in flyteorg/flyte#4874 but never made it into the corresponding flytekit PR #2146 - It's useful for agents to return additional metadata about the job, and it looks like custom_info is the intended location - Make a minor refactor to how the agent responds to requests that return Resource by implementing to_flyte_idl / from_flyte_idl directly Signed-off-by: ddl-ebrown <ethan.brown@dominodatalab.com> Signed-off-by: ddl-rliu <richard.liu@dominodatalab.com> * Fix test Signed-off-by: ddl-rliu <richard.liu@dominodatalab.com> --------- Signed-off-by: ddl-ebrown <ethan.brown@dominodatalab.com> Signed-off-by: ddl-rliu <richard.liu@dominodatalab.com> Co-authored-by: ddl-rliu <richard.liu@dominodatalab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also flyteorg/flyte#5391
Tracking issue
Why are the changes needed?
The agent defines a Resource return type with values:
These are all a part of the underlying protobuf contract defined in
flyteidl.
However, the message field custom_info from the protobuf is not here
google.protobuf.Struct custom_info
https://github.com/flyteorg/flyte/blob/519080b6e4e53fc0e216b5715ad9b5b5270f35c0/flyteidl/protos/flyteidl/admin/agent.proto#L140
This field was added in Agents protocol refactor flyte#4874
but never made it into the corresponding flytekit PR
Add SyncAgentBase #2146
It's useful for agents to return additional metadata about the job,
and it looks like custom_info is the intended location
Make a minor refactor to how the agent responds to requests that
return Resource by implementing to_flyte_idl / from_flyte_idl
directly
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link