Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custominfo to agents #5604

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

ddl-rliu
Copy link
Contributor

@ddl-rliu ddl-rliu commented Jul 29, 2024

Tracking issue

#5603

Why are the changes needed?

Agents may use the Resource object to pass some data back to flyte, but the CustomInfo field is not being passed on in Flyte.

What changes were proposed in this pull request?

Pass on the CustomInfo field in Flyte when receiving a response from agents.

How was this patch tested?

Check that custom_info is correctly passed when calling ListTaskExecutions:

{
    "taskExecutions": [
        {
            "id": {
                "taskId": {
                    "resourceType": "TASK",
                    ...
                },
                ...
            },
            "closure": {
                "phase": "SUCCEEDED",
                "createdAt": "2024-07-29T15:55:54.386882596Z",
                "updatedAt": "2024-07-29T15:58:43.680469958Z",
                "customInfo": {
                    "foo": 100
                },
                ...
            },
            ...
        }
    ],
    ...
}

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

flyteorg/flytekit#2426

Docs link

@ddl-rliu ddl-rliu force-pushed the rliu-add-custom-info-to-agents branch from af15a6e to 252bac0 Compare July 29, 2024 19:38
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.17%. Comparing base (f075b34) to head (afd264f).
Report is 63 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5604       +/-   ##
===========================================
- Coverage   60.92%   36.17%   -24.76%     
===========================================
  Files         796     1302      +506     
  Lines       51689   109494    +57805     
===========================================
+ Hits        31494    39607     +8113     
- Misses      17288    65749    +48461     
- Partials     2907     4138     +1231     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (-17.95%) ⬇️
unittests-flyteadmin 55.33% <ø> (-3.40%) ⬇️
unittests-flytecopilot 12.17% <ø> (-5.62%) ⬇️
unittests-flytectl 62.28% <ø> (-5.14%) ⬇️
unittests-flyteidl 7.08% <ø> (-71.97%) ⬇️
unittests-flyteplugins 53.32% <100.00%> (-8.53%) ⬇️
unittests-flytepropeller 41.74% <ø> (-15.52%) ⬇️
unittests-flytestdlib 55.33% <ø> (-10.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Could we add a small test here?

@ddl-rliu
Copy link
Contributor Author

ddl-rliu commented Aug 19, 2024

Thanks for the pointer, done! afd264f

Signed-off-by: ddl-rliu <richard.liu@dominodatalab.com>
Signed-off-by: ddl-rliu <richard.liu@dominodatalab.com>
@ddl-rliu ddl-rliu force-pushed the rliu-add-custom-info-to-agents branch from 503cbd3 to afd264f Compare August 19, 2024 21:45
@pingsutw pingsutw merged commit 38cc76d into flyteorg:master Aug 23, 2024
47 of 50 checks passed
pmahindrakar-oss pushed a commit that referenced this pull request Sep 9, 2024
Signed-off-by: ddl-rliu <richard.liu@dominodatalab.com>
Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
bgedik pushed a commit to bgedik/flyte that referenced this pull request Sep 12, 2024
Signed-off-by: ddl-rliu <richard.liu@dominodatalab.com>
Signed-off-by: Bugra Gedik <bgedik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants