Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Agents cannot pass custom info back to flyte #5603

Closed
2 tasks done
ddl-rliu opened this issue Jul 29, 2024 · 3 comments
Closed
2 tasks done

[BUG] Agents cannot pass custom info back to flyte #5603

ddl-rliu opened this issue Jul 29, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@ddl-rliu
Copy link
Contributor

ddl-rliu commented Jul 29, 2024

Proposed fix: #5604 flyteorg/flytekit#2426

Describe the bug

Agents may use the Resource object to pass some data back to flyte, but the CustomInfo field is not exposed in this object.

The solution is to enhance flytekit to add this field to the Resource object, and enhance flyte (flyteplugins webapi agent) to read this field from the agent response: flyteorg/flytekit#2426 https://github.com/flyteorg/flyte/pull/5604/files

Expected behavior

Agents should be able to pass custom info back to Flyte. See custom info under https://docs.flyte.org/en/latest/protos/docs/event/event.html#taskexecutionevent

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@ddl-rliu ddl-rliu added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Jul 29, 2024
Copy link

runllm bot commented Jul 29, 2024

The CustomInfo field is indeed a part of the TaskExecutionEvent in Flyte, but it is not currently exposed in the Resource object used by custom agents. According to this discussion, the custom_info field can be used to send plugin-specific execution event information back to Flyte. However, the current implementation does not support this directly.

To address this, Flytekit and Flyte need to be enhanced to include the custom_info field in the Resource object and ensure that Flyte can read this field from the agent response. This would involve updating the Flytekit library to add the custom_info field to the Resource object and modifying Flyte's backend to handle this new field appropriately.

Would you like more detailed steps on how to implement these changes?

Sources:


This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not.

Mention @RunLLM to ask follow-up questions. See runllm.com for more!

@davidmirror-ops davidmirror-ops removed the untriaged This issues has not yet been looked at by the Maintainers label Aug 1, 2024
@davidmirror-ops davidmirror-ops moved this from Backlog to Assigned in Flyte Issues/PRs maintenance Aug 1, 2024
@ddl-rliu
Copy link
Contributor Author

ddl-rliu commented Aug 5, 2024

FYI some PRs which implement a fix to this issue.

#5604 (this should land first)
flyteorg/flytekit#2426 (this should land last)

@ddl-rliu ddl-rliu changed the title [BUG] Custom agents cannot pass custom info back to flyte [BUG] Agents cannot pass custom info back to flyte Aug 9, 2024
@eapolinario eapolinario assigned pingsutw and unassigned eapolinario Aug 15, 2024
@ddl-rliu
Copy link
Contributor Author

Closing since both PRs have been merged. Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants