-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Code Quality: Introducing StandardViewBase to reduce code duplication #10996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Setting this up as a draft so discussions may ensue to make sure it goes into the right direction. |
@QuaintMako what are your plans for the current BaseLayout, will that be removed? |
What I aim with this PR is to reduce the duplication inside For now there is no plan around the BaseLayout. But looking at it, we may have ways to simplify it. |
Opening up this PR for a first refactoring of the different views. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
Items resolved / related issues by this PR.
What is the purpose of that PR.
A lot of code duplication can be found inside the ViewBrowsers. This PR aims at reducing the duplication by combining the concerned classes inside a standard view.
This preliminary work has for objective to pave the way to a tackle #1928 further down the line.
What has been done
StandardViewBase
to gather up the duplicated code inGridViewBrowser
,ColumnViewBase
andGridViewBrowser
.Validation
How did you test these changes?