Skip to content

Fix: Fixed issue with using arrow keys while renaming a file #11028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ferrariofilippo
Copy link
Contributor

… other files

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2 yaira2 changed the title Fixed: using the arrow keys when renaming a file will start selecting… Fix: Fixed issue with using arrow keys while renaming a file Jan 16, 2023
@yaira2
Copy link
Member

yaira2 commented Jan 16, 2023

Does this need to be applied to the other layouts? Why was the search control modified?

@ferrariofilippo
Copy link
Contributor Author

I tested it on tiles and grid, as soon as I can I'll do it for details and columns.
I changed search control since the same issue involved it (see Josh comment in the issue)

@ferrariofilippo
Copy link
Contributor Author

as soon as I can I'll do it for details and columns.

Left/Right arrows work. Up/Down select files above/below. I'll fix this

@ferrariofilippo
Copy link
Contributor Author

Last commit doesn't fully resolve the problem. There's a bug when you're at the beginning of a word and press Down Arrow. Nothing happens in this case and also in the opposite one (you're at the end and press Up Arrow). At the moment I know that in this case KeyDown event is not raised. We can't resolve the issue adding an event handler to PreviewKeyDown since this event gives no information about modifiers

@ferrariofilippo
Copy link
Contributor Author

I'll open a new PR after #10996 is merged

@ferrariofilippo ferrariofilippo deleted the Fixed_Renaming_Using_Arrows branch January 23, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming a file using the arrow keys to navigate words in its name, will start selecting other files
3 participants