Skip to content

Code Quality: Introducing StandardViewBase to reduce code duplication #10996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Files.App/App.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<GradientStop Offset="1.0" Color="{ThemeResource ControlStrokeColorDefault}" />
</LinearGradientBrush.GradientStops>
</LinearGradientBrush>

<ResourceDictionary.MergedDictionaries>
<XamlControlsResources xmlns="using:Microsoft.UI.Xaml.Controls" />
<ResourceDictionary>
Expand Down
1 change: 0 additions & 1 deletion src/Files.App/BaseLayout.cs
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,6 @@ internal set
}

NotifyPropertyChanged(nameof(SelectedItems));
//ItemManipulationModel.SetDragModeForItems();
}

ParentShellPageInstance!.ToolbarViewModel.SelectedItems = value;
Expand Down
2 changes: 1 addition & 1 deletion src/Files.App/Dialogs/CreateArchiveDialog.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@
Grid.Row="0"
Grid.Column="1"
Width="160"
DisplayMemberPath="Label"
ItemsSource="{x:Bind ViewModel.FileFormats}"
SelectedItem="{x:Bind ViewModel.FileFormat, Mode=TwoWay}"
DisplayMemberPath="Label"
SelectedValuePath="Key" />

<!-- Compression Level -->
Expand Down
8 changes: 4 additions & 4 deletions src/Files.App/Dialogs/CreateShortcutDialog.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
Title="{helpers:ResourceString Name=NewShortcutDialogTitle}"
DefaultButton="Primary"
PrimaryButtonCommand="{x:Bind ViewModel.PrimaryButtonCommand}"
IsPrimaryButtonEnabled="{x:Bind ViewModel.IsLocationValid, Mode=OneWay}"
PrimaryButtonCommand="{x:Bind ViewModel.PrimaryButtonCommand}"
PrimaryButtonText="{helpers:ResourceString Name=Create}"
RequestedTheme="{x:Bind helpers:ThemeHelper.RootTheme}"
SecondaryButtonText="{helpers:ResourceString Name=Cancel}"
Expand All @@ -29,11 +29,11 @@
<RowDefinition Height="Auto" />
<RowDefinition Height="Auto" />
</Grid.RowDefinitions>

<!-- Header -->
<TextBlock
<TextBlock
Grid.ColumnSpan="2"
Margin="0, 0, 0, 20"
Margin="0,0,0,20"
Text="{helpers:ResourceString Name=NewShortcutDialogDescription}"
TextWrapping="Wrap" />

Expand Down
4 changes: 1 addition & 3 deletions src/Files.App/UserControls/FilePreviews/CodePreview.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@
Loaded="UserControl_Loaded"
mc:Ignorable="d">
<Border>
<ScrollViewer
HorizontalScrollBarVisibility="Auto"
HorizontalScrollMode="Auto">
<ScrollViewer HorizontalScrollBarVisibility="Auto" HorizontalScrollMode="Auto">
<RichTextBlock
Name="codeView"
Padding="10"
Expand Down
4 changes: 1 addition & 3 deletions src/Files.App/UserControls/FilePreviews/MediaPreview.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@
Foreground="Transparent"
Source="{x:Bind ViewModel.Source, Mode=OneWay}">
<MediaPlayerElement.TransportControls>
<MediaTransportControls
IsPlaybackRateButtonVisible="False"
IsZoomButtonVisible="False" />
<MediaTransportControls IsPlaybackRateButtonVisible="False" IsZoomButtonVisible="False" />
</MediaPlayerElement.TransportControls>
</MediaPlayerElement>
</Border>
Expand Down
2 changes: 1 addition & 1 deletion src/Files.App/UserControls/Pane/PreviewPane.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@
<StackPanel Orientation="Vertical">
<TextBlock
x:Name="DetailsListHeader"
HorizontalAlignment="Center"
FontSize="20"
FontWeight="Bold"
HorizontalAlignment="Center"
IsTextSelectionEnabled="True"
Text="{x:Bind ViewModel.SelectedItem.Name, Mode=OneWay}"
TextAlignment="Center"
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/UserControls/SearchBox.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,15 @@

<AutoSuggestBox
x:Name="SearchRegion"
GotFocus="{x:Bind SearchBoxViewModel.SearchRegion_GotFocus}"
ItemTemplate="{StaticResource SuggestionTemplate}"
ItemsSource="{x:Bind SearchBoxViewModel.Suggestions, Mode=OneWay}"
PlaceholderText="{helpers:ResourceString Name=NavigationToolbarSearchRegion/PlaceholderText}"
QuerySubmitted="SearchRegion_QuerySubmitted"
Text="{x:Bind SearchBoxViewModel.Query, Mode=TwoWay}"
TextBoxStyle="{StaticResource TextBoxStyle}"
TextChanged="SearchRegion_TextChanged"
UpdateTextOnSelect="False"
GotFocus="{x:Bind SearchBoxViewModel.SearchRegion_GotFocus}">
UpdateTextOnSelect="False">
<AutoSuggestBox.QueryIcon>
<AnimatedIcon x:Name="SearchAnimatedIcon" Height="16">
<AnimatedIcon.Source>
Expand Down
10 changes: 5 additions & 5 deletions src/Files.App/UserControls/SidebarControl.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,13 @@
<ResourceDictionary>
<!-- Removes NavigationView background -->
<SolidColorBrush x:Key="NavigationViewContentBackground" Color="Transparent" />

<!-- Removes NavigationView corner radius -->
<CornerRadius x:Key="NavigationViewContentGridCornerRadius">0</CornerRadius>

<!-- Removes NavigationView border from top, right and bottom -->
<Thickness x:Key="NavigationViewContentGridBorderThickness">1,0,0,0</Thickness>

<mconv:BoolNegationConverter x:Key="BoolNegationConverter" />
<mconv:StringFormatConverter x:Key="StringFormatConverter" />
<vc:ColorModelToColorConverter x:Key="ColorModelToColorConverter" />
Expand Down Expand Up @@ -420,8 +420,8 @@
<Grid
x:Name="ContentRoot"
Grid.Row="2"
Background="{ThemeResource App.Theme.FileArea.BackgroundBrush}"
Grid.ColumnSpan="2">
Grid.ColumnSpan="2"
Background="{ThemeResource App.Theme.FileArea.BackgroundBrush}">
<Grid.RenderTransform>
<CompositeTransform x:Name="ContentTransform" />
</Grid.RenderTransform>
Expand Down Expand Up @@ -1195,6 +1195,6 @@
DriveNavItemTemplate="{StaticResource DriveNavItem}"
FileTagNavItemTemplate="{StaticResource FileTagNavItem}"
LinuxNavItemTemplate="{StaticResource LinuxNavItem}"
LocationNavItemTemplate="{StaticResource LocationNavItem}"/>
LocationNavItemTemplate="{StaticResource LocationNavItem}" />
</NavigationView.MenuItemTemplateSelector>
</NavigationView>
2 changes: 1 addition & 1 deletion src/Files.App/UserControls/Widgets/RecentFilesWidget.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
xmlns:fs="using:Files.App.Filesystem"
xmlns:helpers="using:Files.App.Helpers"
xmlns:muxc="using:Microsoft.UI.Xaml.Controls"
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
xmlns:muxc="using:Microsoft.UI.Xaml.Controls"
Background="{ThemeResource SolidBackgroundFillColorBaseBrush}"
mc:Ignorable="d">

Expand Down
8 changes: 4 additions & 4 deletions src/Files.App/Views/LayoutModes/ColumnViewBase.xaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<local:BaseLayout
<local:StandardViewBase
x:Class="Files.App.Views.LayoutModes.ColumnViewBase"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
Expand All @@ -15,7 +15,7 @@
xmlns:vc="using:Files.App.ValueConverters"
x:Name="PageRoot"
mc:Ignorable="d">
<local:BaseLayout.Resources>
<local:StandardViewBase.Resources>
<vc:ColorModelToColorConverter x:Key="ColorModelToColorConverter" />
<converters:BoolNegationConverter x:Key="BoolNegationConverter" />
<converters:BoolToVisibilityConverter
Expand Down Expand Up @@ -120,7 +120,7 @@
</Setter.Value>
</Setter>
</Style>
</local:BaseLayout.Resources>
</local:StandardViewBase.Resources>

<Grid x:Name="RootGrid" ContextFlyout="{x:Bind BaseContextMenuFlyout}">
<uc:FolderEmptyIndicator
Expand Down Expand Up @@ -449,4 +449,4 @@
StrokeThickness="1" />
</Canvas>
</Grid>
</local:BaseLayout>
</local:StandardViewBase>
Loading