Skip to content

Feature: Added option to show check boxes next to file names #11017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Jan 19, 2023
Merged

Feature: Added option to show check boxes next to file names #11017

merged 35 commits into from
Jan 19, 2023

Conversation

marcelwgn
Copy link
Contributor

@marcelwgn marcelwgn commented Jan 15, 2023 •
edited
Loading

Changes:

  1. Select all column for DetailView/Adaptive View
  2. Remove multi select for ColumnView
  3. Move MultiSelect option from toolbar to settings

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

Screenshot of listview with selected item

Screenshot of GridView with selected item

@marcelwgn marcelwgn requested a review from yaira2 January 15, 2023 18:57
@marcelwgn
Copy link
Contributor Author

@QuaintMako FIY since there are some changes to the two DetailViewLayout and the GridViewLayout that we could potentially also converge in #10996 .

yaira2
yaira2 reviewed Jan 15, 2023
View reviewed changes
yaira2
yaira2 reviewed Jan 15, 2023
View reviewed changes
@yaira2 yaira2 changed the title Feature: Change/improve multi selection behaviour Feature: Improved multiselect feature Jan 15, 2023
yaira2
yaira2 reviewed Jan 15, 2023
View reviewed changes
@yaira2 yaira2 requested a review from gave92 January 15, 2023 20:54
yaira2
yaira2 reviewed Jan 15, 2023
View reviewed changes
@marcelwgn marcelwgn requested a review from yaira2 January 15, 2023 23:00
yaira2
yaira2 reviewed Jan 15, 2023
View reviewed changes
@yaira2 yaira2 changed the title Feature: Improved multiselect feature Feature: Added option to show check boxes next to file names Jan 16, 2023
yaira2
yaira2 reviewed Jan 16, 2023
View reviewed changes
yaira2
yaira2 reviewed Jan 16, 2023
View reviewed changes
@QuaintMako
Copy link
Contributor

@QuaintMako FIY since there are some changes to the two DetailViewLayout and the GridViewLayout that we could potentially also converge in #10996 .

Thanks for the heads up, I'll wait for your work to be done so I can get this into #10996.

yaira2
yaira2 previously approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@gave92 do you want to look this over as well?

yaira2
yaira2 previously approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yaira2
yaira2 previously approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

QuaintMako
QuaintMako reviewed Jan 18, 2023
View reviewed changes
QuaintMako
QuaintMako previously approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just being a bit picky on the formatting.

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 19, 2023
@marcelwgn marcelwgn dismissed stale reviews from QuaintMako and yaira2 via 9825a0f January 19, 2023 07:43
@yaira2 yaira2 merged commit 05c4ace into files-community:main Jan 19, 2023
@Josh65-2201 Josh65-2201 mentioned this pull request Jan 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuaintMako QuaintMako QuaintMako approved these changes

@yaira2 yaira2 yaira2 left review comments

@gave92 gave92 Awaiting requested review from gave92

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Improving multiselect feature
3 participants
@marcelwgn @QuaintMako @yaira2