Skip to content

Fix: Fixed issue where there were multiple "home" items in the sidebar #10141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 6, 2022
Merged

Fix: Fixed issue where there were multiple "home" items in the sidebar #10141

merged 6 commits into from
Oct 6, 2022

Conversation

QuaintMako
Copy link
Contributor

Resolved / Related Issues

What has been done

  • Home is no longer added two times on the Sidebar.
  • Fixed some conditions that were wrong.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

yaira2
yaira2 reviewed Oct 6, 2022
View reviewed changes
yaira2
yaira2 reviewed Oct 6, 2022
View reviewed changes
yaira2
yaira2 approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix: Side bar refactoring side effect Fixed: Fixed issue where there were multiple "home" items in the sidebar Oct 6, 2022
@yaira2 yaira2 changed the title Fixed: Fixed issue where there were multiple "home" items in the sidebar Fix: Fixed issue where there were multiple "home" items in the sidebar Oct 6, 2022
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 6, 2022
@yaira2 yaira2 merged commit 5863f44 into files-community:main Oct 6, 2022
@QuaintMako QuaintMako deleted the SideBar_Refactoring_SideEffectFix branch October 9, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Duplicate "home" items in the sidebar
2 participants
@QuaintMako @yaira2