Skip to content

Code quality: Reduced duplicate code for the sidebar #10114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Oct 3, 2022
Merged

Code quality: Reduced duplicate code for the sidebar #10114

merged 19 commits into from
Oct 3, 2022

Conversation

QuaintMako
Copy link
Contributor

Resolved / Related Issues

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@QuaintMako
Made the section order a field.
de74fbc
@QuaintMako
Cutting the function GetOrCreateSection intwo two subfunctions.
5cf614d
@QuaintMako
Harmonized the icon creation.
187a898
@QuaintMako
Introducing a variable handling the icon.
308e214
@QuaintMako
Reverse the icon set up (async issues) + AddSectionToSidebar function.
d66326e
@QuaintMako
Introduced a Build Section method
690b4a8
@QuaintMako
Used the BuildSection() method for Home section.
e72c3b8
@QuaintMako
Moved the font family setup from the BuildSection method.
196db46
@QuaintMako
Changed the switch case into a if/elif.
58e80bb
@QuaintMako
Used defined properties to shorten conditions.
313ff1a
@QuaintMako
Harmonized the section icon setting and adding to the sidebar.
d9426ff
@QuaintMako
Changed some hardcoded paths to icons into constants.
2621435
@QuaintMako
Reordered using imports.
f52d217
@QuaintMako
Removed space that weren't supposed to be here.
595cb4a
@QuaintMako
Merge branch 'main' into SideBar_SectionBuilding_Refactoring
3fddcb2
@QuaintMako
Change if/else statement into switch case.
3b955e7
@QuaintMako
Fixed some formatting on if/else
c552049
@QuaintMako
Fixing some formatting.
7d20193
yaira2
yaira2 approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the base branch from main to ya/CodeCleanup October 3, 2022 18:13
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Oct 3, 2022
@yaira2 yaira2 merged commit d15c876 into files-community:ya/CodeCleanup Oct 3, 2022
This was referenced Oct 6, 2022
Closed
Merged
@QuaintMako QuaintMako deleted the SideBar_SectionBuilding_Refactoring branch October 9, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidebar section creation has a lot of duplicated code
2 participants
@QuaintMako @yaira2