-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regular Expression Denial of Service vulerability in "ws" package #31646
Comments
although I see #31648 is closed, I am still seeing this vulnerable version of "ws" in react-native 0.69.2, and in the 'main' development branch. Forgive my ignorance as I'm trying to understand the process. I'm confused about how to know whether this means it will be included in an upcoming release or not (also whether its better to comment here, or on the closed issue which seemingly has merged the fix). Can someone clarify what is the status? Also, I saw in #20222 a developer indicated that 'ws' is only for development/testing purposes; if this is true, is there a reason its not in the 'devDependencies' section? Thanks |
Please note that #31648 was never merged.
Not sure at this stage, but it should be fine sending a PR for moving it + bumping. We can take a look at what are the current blockers. |
Summary: A moderate vulnerability was found in all versions of `ws` below 7.4.6 June last year. React native current uses v6.1.4 which is susceptible to it, fortunately this security fix has been backported to v6.X.X and we don't need to upgrade any major versions/worry about breaking changes. This PR bumps `ws` to 6.2.2 ([CHANGELOG](https://github.com/websockets/ws/releases/tag/6.2.2)) due to this ReDoS vulnerability More information about this vulnerability can be found here -> GHSA-6fc8-4gx4-v693 Closes facebook#31646 ## Changelog [Internal] [Security] - Bump ws to 6.2.2 due to ReDoS vulnerability Pull Request resolved: facebook#34759 Test Plan: Ensure WebSocket tests are working as expected Tested HMR working on Twilight | iOS | Android | | https://pxl.cl/2g70M | https://pxl.cl/2g70V | Reviewed By: hramos, cortinico Differential Revision: D39722905 fbshipit-source-id: 12088ab5ea26d904675de484e2014949d6696465
Description
React Native is using version
6.1.4
ofws
. A new moderate vulnerability has been found for versions below7.4.6
: https://www.npmjs.com/advisories/1748.Please consider upgrading
ws
to7.4.6
.React Native version:
Steps To Reproduce
npm audit
Expected Results
No vulnerabilities found
Snack, code example, screenshot, or link to a repository:
The text was updated successfully, but these errors were encountered: