build: Bump ws to 6.2.2 due to ReDoS vulnerability #34759
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Base commit: 108c876 |
Base commit: 108c876 |
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
gabrieldonadel
force-pushed
the
feat/bump-ws
branch
from
be26d13
to
7aadd46
Compare
|
Hey @gabrieldonadel, can I ask you to rebase? The CI should be green then. |
gabrieldonadel
force-pushed
the
feat/bump-ws
branch
from
7aadd46
to
50c6c1d
Compare
Sounds good, I've just pushed a commit rebasing it |
gabrieldonadel
force-pushed
the
feat/bump-ws
branch
from
50c6c1d
to
388b1f1
Compare
|
@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @gabrieldonadel in fa22a6e. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: A moderate vulnerability was found in all versions of `ws` below 7.4.6 June last year. React native current uses v6.1.4 which is susceptible to it, fortunately this security fix has been backported to v6.X.X and we don't need to upgrade any major versions/worry about breaking changes. This PR bumps `ws` to 6.2.2 ([CHANGELOG](https://github.com/websockets/ws/releases/tag/6.2.2)) due to this ReDoS vulnerability More information about this vulnerability can be found here -> GHSA-6fc8-4gx4-v693 Closes facebook#31646 ## Changelog [Internal] [Security] - Bump ws to 6.2.2 due to ReDoS vulnerability Pull Request resolved: facebook#34759 Test Plan: Ensure WebSocket tests are working as expected Tested HMR working on Twilight | iOS | Android | | https://pxl.cl/2g70M | https://pxl.cl/2g70V | Reviewed By: hramos, cortinico Differential Revision: D39722905 fbshipit-source-id: 12088ab5ea26d904675de484e2014949d6696465
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A moderate vulnerability was found in all versions of
wsbelow 7.4.6 June last year. React native current uses v6.1.4 which is susceptible to it, fortunately this security fix has been backported to v6.X.X and we don't need to upgrade any major versions/worry about breaking changes. This PR bumpswsto 6.2.2 (CHANGELOG) due to this ReDoS vulnerabilityMore information about this vulnerability can be found here -> GHSA-6fc8-4gx4-v693
Closes #31646
Changelog
[Internal] [Security] - Bump ws to 6.2.2 due to ReDoS vulnerability
Test Plan
Ensure WebSocket tests are working as expected