-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ws package #20222
Upgrade ws package #20222
Conversation
Generated by 🚫 dangerJS |
Thank you for bringing this up! Be safe, |
@singingwolfboy I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This has been a surprisingly difficult pull request to land. The Considering this is not exactly blocking React Native, I lean towards closing this PR. Once |
Security fix for https://nodesecurity.io/advisories/550 (rating: HIGH)
The
ws
project uses GitHub releases for a ChangeLog.Test Plan:
I haven't tested this change yet -- I'm not familiar with how the
ws
package works, and I expect there are some backwards-incompatible changes between version 1 and version 5. I wanted to make this pull request anyway, in the hopes that someone more familiar with this package would be able to review it and suggest changes for the codebase.Release Notes:
[INTERNAL] [BUGFIX] [package.json] - Upgrade the
ws
package, to close a security vulnerability