Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ws per: https://www.npmjs.com/advisories/1748 #31648

Closed
wants to merge 1 commit into from

Conversation

rickycodes
Copy link

@rickycodes rickycodes commented Jun 3, 2021

Summary

re: #31646

this brings Moderate vulnerabilities from down to 211 from 213.

To be completely rid of the ws vuln it also needs to be bumped to 7.4.6 in jest in @react-native/repo-config and in react-devtools-core.

Changelog

[Internal] [Security] - Update ws

Test Plan

@rickycodes rickycodes requested a review from hramos as a code owner June 3, 2021 02:48
@facebook-github-bot
Copy link
Contributor

Hi @rickycodes!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@pull-bot
Copy link

pull-bot commented Jun 3, 2021

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 3129b93

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 58444c7

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,238,889 +0
android hermes armeabi-v7a 8,749,243 +0
android hermes x86 9,701,297 +0
android hermes x86_64 9,666,397 +0
android jsc arm64-v8a 10,886,602 +0
android jsc armeabi-v7a 9,788,239 +0
android jsc x86 10,944,412 +0
android jsc x86_64 11,551,045 +0

Base commit: 58444c7

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 3, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@brunobar79
Copy link
Contributor

This breaks debug mode with hermes ON

@rickycodes
Copy link
Author

ah yea i see it needs to be updated in metro too. okay! nvm. not as trivial as i thought

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants