-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ws per: https://www.npmjs.com/advisories/1748 #31648
Conversation
Hi @rickycodes! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Base commit: 58444c7 |
Base commit: 58444c7 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This breaks debug mode with hermes ON |
ah yea i see it needs to be updated in metro too. okay! nvm. not as trivial as i thought |
Summary
re: #31646
this brings Moderate vulnerabilities from down to
211
from213
.To be completely rid of the
ws
vuln it also needs to be bumped to7.4.6
injest
in@react-native/repo-config
and inreact-devtools-core
.Changelog
[Internal] [Security] - Update ws
Test Plan